Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping for nullbits tidbit board with bit-c pro #916

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

patricksurry
Copy link
Contributor

Split from #915 after review by board owner. cc @jaygreco

@patricksurry
Copy link
Contributor Author

the contribution guidelines lint make fix-isort fix-formatting test makes changes to a bunch of other files I haven't touched. but it also doesn't seem to match GHA which complained about double-quoted doc string after lint passes?

I can add the lint changes to the other files here if that's helpful, just lmk

@xs5871
Copy link
Collaborator

xs5871 commented Dec 8, 2023

GHA runs make lint for linting. The fix-* targets are for mostly automatic fixing of lint errors and are meant to be run manually before a commit. The lint and fix targets run different tools and have slightly different code coverage for some historical reason... There can sometimes be differences, this time it's something on your side though. Maybe your master branch or your tooling is out of date.

@xs5871 xs5871 merged commit ee27388 into KMKfw:master Dec 8, 2023
1 check passed
hixan pushed a commit to hixan/kmk_firmware that referenced this pull request Feb 21, 2024
Adds nullbits tidbit board and bitc promicro mapping
hixan pushed a commit to hixan/kmk_firmware that referenced this pull request Nov 4, 2024
Adds nullbits tidbit board and bitc promicro mapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants