Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to vkCmdPushDescriptorSetWithTemplateKHR(). #2327

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

billhollings
Copy link
Contributor

  • Fix crash when entries in VkDescriptorUpdateTemplateCreateInfo are not sorted by offset.
  • MVKCmdPushDescriptorSetWithTemplate allocate new data memory only if existing memory allocation is too small.
  • mvkCopy() support void pointers, and copy a single value directly.

Fixes issue #2323.

- Fix crash when entries in VkDescriptorUpdateTemplateCreateInfo
  are not sorted by offset.
- MVKCmdPushDescriptorSetWithTemplate allocate new data memory
  only if existing memory allocation is too small.
- mvkCopy() support void pointers, and copy a single value directly.
Copy link
Collaborator

@cdavis5e cdavis5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing.

MoltenVK/MoltenVK/Commands/MVKCmdPipeline.mm Show resolved Hide resolved
@billhollings billhollings merged commit ed88968 into KhronosGroup:main Sep 6, 2024
6 checks passed
@billhollings billhollings deleted the push-template-fixes branch September 6, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants