Update clUpdateMutableCommandsKHR binding #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bashbaug
reviewed
Jul 31, 2024
There was a problem hiding this comment.
These changes look good, but they'll break without the corrosponding header updates. Should we use the extension versioning mechanism to either a) only expose this function when the headers are sufficiently new, or b) select between both versions, for some time at least?
In OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1045 the API for `cl_khr_command_buffer_mutable_dispatch` API `clUpdateMutableCommandsKHR` changed in a breaking way. When the headers update OpenCL-Headers PR KhronosGroup/OpenCL-Headers#245 the bindings will break if they are not updated to reflect this change. Bindings updated in this PR to pass to arrays of templated length to the C++ method. The underlying `.data()` pointers of these parameters can be passed through to the OpenCL API.
I forgot to reply when I made this change, but I updated to option b) |
bashbaug
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1045 the API for
cl_khr_command_buffer_mutable_dispatchAPIclUpdateMutableCommandsKHRchanged in a breaking way.When the headers update OpenCL-Headers PR KhronosGroup/OpenCL-Headers#245 the bindings will break if they are not updated to reflect this change.
Bindings updated in this PR to pass to arrays of templated length to the C++ method. The underlying
.data()pointers of these parameters can be passed through to the OpenCL API. I don't think any tests for this API currently exist in the repo to be updated.