Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enabling narrowing errors #1144

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Re-enabling narrowing errors #1144

wants to merge 4 commits into from

Commits on Sep 22, 2024

  1. Re-enabling narrowing errors 

    Fixes narrowing conversion build errors in test_common

Removing disable of narrowing errors in main CMakeLists.txt
and moving it down to test_conformance CMakeLists.txt where
there are many more build errors revealed from this fix

Contributes KhronosGroup#787

Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>
    @ellnor01 @ahesham-arm
    ellnor01 authored and ahesham-arm committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    65412cc View commit details
    Browse the repository at this point in the history

  2. Enable narrowing errors for more directories 

    Moves -Wno-narrowing down to only run on suites with
many narrowing errors.

Includes some quick fixes for one-off errors this caused.

Contributes KhronosGroup#787

Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>
    @ellnor01 @ahesham-arm
    ellnor01 authored and ahesham-arm committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    fdc4090 View commit details
    Browse the repository at this point in the history

  3. Make Version function to_uint() for consistency 

    Includes fix for MacOS build error

Contributes KhronosGroup#787

Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>
    @ellnor01 @ahesham-arm
    ellnor01 authored and ahesham-arm committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    5afa2a4 View commit details
    Browse the repository at this point in the history

  4. Fix narrowing errors in compiler and spirv_new 

    Contributes KhronosGroup#787

Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>
    @ellnor01 @ahesham-arm
    ellnor01 authored and ahesham-arm committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    a27cdc3 View commit details
    Browse the repository at this point in the history