Re-enabling narrowing errors #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellnor01
force-pushed
the
narrowing_conversion_1
branch
5 times, most recently
from
e41f811
to
f46c622
Compare
ellnor01
force-pushed
the
narrowing_conversion_1
branch
from
c16511e
to
25983c6
Compare
|
Any comments on here? |
This was referenced May 20, 2021
ahesham-arm
force-pushed
the
narrowing_conversion_1
branch
from
25983c6
to
629fb20
Compare
|
@ahesham-arm This is failing the CI. It may require a rebase and/or fixes. |
ahesham-arm
force-pushed
the
narrowing_conversion_1
branch
3 times, most recently
from
08da74d
to
2b418b0
Compare
|
@kpet Rebased and all CI checks are now passing. |
bashbaug
reviewed
Jul 9, 2024
test_conformance/extensions/cl_khr_command_buffer/command_buffer_printf.cpp
Outdated
Show resolved
Hide resolved
ahesham-arm
force-pushed
the
narrowing_conversion_1
branch
from
2b418b0
to
d5937ea
Compare
lakshmih
reviewed
Jul 23, 2024
| @@ -274,7 +274,7 @@ struct CommandBufferPrintfTest : public BasicCommandBufferTest | |||
| &pattern[0], 0, nullptr, nullptr); | |||
| test_error(error, "clEnqueueWriteBuffer failed"); | |||
|
|
|||
| cl_int offset[] = { 0, pattern.size() - 1 }; | |||
| size_t offset[] = { 0, pattern.size() - 1 }; | |||
| error = clEnqueueWriteBuffer(queue, off_mem, CL_TRUE, 0, sizeof(offset), | |||
| offset, 0, nullptr, nullptr); | |||
| test_error(error, "clEnqueueWriteBuffer failed"); | |||
There was a problem hiding this comment.
off_mem is created for sizeof(cl_int) size so I think the enqueuewritebuffer to it using sizeof(size_t) can cause issues.
There was a problem hiding this comment.
This is now using cl_uint for the type of the array and an assert is added to ensure the casting is safe.
lakshmih
reviewed
Jul 23, 2024
| @@ -115,7 +115,8 @@ struct CreateCommandBufferRepeatedProperties : public BasicCommandBufferTest | |||
| TEST_FAIL); | |||
|
|
|||
| cl_command_buffer_properties_khr invalid_properties[3] = { | |||
| CL_COMMAND_BUFFER_FLAGS_KHR, CL_INVALID_PROPERTY, 0 | |||
| CL_COMMAND_BUFFER_FLAGS_KHR, | |||
| (cl_command_buffer_properties_khr)CL_INVALID_PROPERTY, 0 | |||
| }; | |||
There was a problem hiding this comment.
Not sure CL_INVALID_PROPERTY can be used in a property list like this. The spec only specifies its usage as a return value.
There was a problem hiding this comment.
I have used -1 instead.
Fixes narrowing conversion build errors in test_common Removing disable of narrowing errors in main CMakeLists.txt and moving it down to test_conformance CMakeLists.txt where there are many more build errors revealed from this fix Contributes KhronosGroup#787 Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>
ahesham-arm
force-pushed
the
narrowing_conversion_1
branch
from
d5937ea
to
2c9e7d3
Compare
Moves -Wno-narrowing down to only run on suites with many narrowing errors. Includes some quick fixes for one-off errors this caused. Contributes KhronosGroup#787 Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>
Includes fix for MacOS build error Contributes KhronosGroup#787 Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>
Contributes KhronosGroup#787 Signed-off-by: Ellen Norris-Thompson <ellen.norris-thompson@arm.com>
ahesham-arm
force-pushed
the
narrowing_conversion_1
branch
from
2c9e7d3
to
a27cdc3
Compare
bashbaug
approved these changes
Sep 30, 2024
lakshmih
approved these changes
Oct 4, 2024
|
Merging as discussed in the October 8th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes narrowing conversion build errors in test_common
Removing disable of narrowing errors in main CMakeLists.txt
and moving it down to specific test_conformance suite's
CMakeLists.txt where there are many more build errors revealed
from this fix.
Fixes a few simple issues under test_conformance in the process.
Contributes #787
Signed-off-by: Ellen Norris-Thompson ellen.norris-thompson@arm.com