Add arguments tests for cl_khr_command_buffer_mutable_dispatch. #1749

pj87 · 2023-05-29T13:08:39Z

No description provided.

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp

… arguments test. Applied review comments for mutable dispatch global arguments test: - clFinish to ensure command-buffer has finished executing for calling clUpdateMutableCommandsKHR - Add second clEnqueueCommandBufferKHR for the command-buffer again before calling clEnqueueReadBuffer so that the kernel runs with the new argument Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

…tch arguments test. Applied review comments for remaining mutable dispatch arguments test: - clFinish to ensure command-buffer has finished executing for calling clUpdateMutableCommandsKHR Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

bashbaug

I made a bunch of fixes to these tests as a PR to your branch here: pj87#1. Can you check that the fixes were incorporated even if you don't merge the PR? It seems like a lof the issues still remain.

...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

EwanC

Seeing the tests pass apart from SVM

...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp

EwanC · 2023-06-28T08:03:31Z

...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp

+ /* Set the arguments */
+ error = clSetKernelArg(kernel, 0, sizeof(cl_mem), &streams[0]);
+ test_error(error, "Unable to set indexed kernel arguments");
+ error = clSetKernelArg(kernel, 1, sizeof(cl_mem) * 2, nullptr);


why sizeof(cl_mem) * 2 number of bytes of local data rather than based on numberOfInts

...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp

Changes made: - Remove unneeded headers - Remove unneeded variable - Remove unneeded skip condition - Fix type int -> cl_int Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

bashbaug

Merging as discussed in the July 11th teleconference.

Add arguments tests for cl_khr_command_buffer_mutable_dispatch.

55720bf

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

EwanC reviewed May 29, 2023

View reviewed changes

...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp Show resolved Hide resolved

...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp Outdated Show resolved Hide resolved

pj87 added 4 commits May 29, 2023 18:06

Fix clang format.

d590d31

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

Fix clang format.

5ff68af

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

This was referenced May 31, 2023

Add global size tests for cl_khr_command_buffer_mutable_dispatch. #1744

Merged

Add dispatch arguments tests for cl_khr_command_buffer_mutable_dispatch. #1748

Closed

Merge branch 'main' into Mutable-command-arguments

b180569

bashbaug added the focused review label Jun 12, 2023

bashbaug requested changes Jun 13, 2023

View reviewed changes

...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp Outdated Show resolved Hide resolved

pj87 added 3 commits June 19, 2023 12:16

Recover proper MutableDispatchGlobalArguments test.

d5d5712

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

Recover proper MutableDispatchNullArguments test.

63238ab

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

Fix constant magic number.

a6d4a96

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

EwanC reviewed Jun 28, 2023

View reviewed changes

pj87 added 6 commits June 30, 2023 13:15

Fix review changes.

a0e1207

Changes made: - Remove unneeded headers - Remove unneeded variable - Remove unneeded skip condition - Fix type int -> cl_int Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

Merge branch 'main' into Mutable-command-arguments

8669f45

Fix tests definitions.

8d80956

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

Fix compilation error.

df2141c

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

Fix clang format.

26ca641

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

Fix clang format.

0eabd79

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

EwanC reviewed Jul 3, 2023

View reviewed changes

Fix review comments.

43ec10b

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

EwanC reviewed Jul 3, 2023

View reviewed changes

pj87 added 4 commits July 3, 2023 14:58

Fix review comments.

c16fc65

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

Fix clang format.

4810b7d

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

Fix review comments.

8cfd783

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

Fix review comments.

a82e3a0

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

EwanC previously approved these changes Jul 4, 2023

View reviewed changes

...s/cl_khr_command_buffer/cl_khr_command_buffer_mutable_dispatch/mutable_command_arguments.cpp Outdated Show resolved Hide resolved

Fix review comments.

5e485af

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

pj87 dismissed EwanC’s stale review via 5e485af July 4, 2023 09:32

EwanC previously approved these changes Jul 4, 2023

View reviewed changes

Fix clang format.

aa33e4e

Signed-off-by: Paweł Jastrzębski <p.k.jastrzebski@gmail.com>

pj87 dismissed EwanC’s stale review via aa33e4e July 4, 2023 09:48

EwanC mentioned this pull request Jul 6, 2023

Test cl_khr_command_buffer_mutable_dispatch #1481

Closed

21 tasks

EwanC previously approved these changes Jul 7, 2023

View reviewed changes

Merge branch 'main' into Mutable-command-arguments

7129505

pj87 dismissed EwanC’s stale review via 7129505 July 11, 2023 17:49

EwanC approved these changes Jul 11, 2023

View reviewed changes

bashbaug approved these changes Jul 11, 2023

View reviewed changes

bashbaug merged commit c69bc00 into KhronosGroup:main Jul 11, 2023
6 checks passed

pj87 deleted the Mutable-command-arguments branch November 10, 2023 18:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add arguments tests for cl_khr_command_buffer_mutable_dispatch. #1749

Add arguments tests for cl_khr_command_buffer_mutable_dispatch. #1749

pj87 commented May 29, 2023

bashbaug left a comment

EwanC left a comment

EwanC Jun 28, 2023

bashbaug left a comment

Add arguments tests for cl_khr_command_buffer_mutable_dispatch. #1749

Add arguments tests for cl_khr_command_buffer_mutable_dispatch. #1749

Conversation

pj87 commented May 29, 2023

bashbaug left a comment

Choose a reason for hiding this comment

EwanC left a comment

Choose a reason for hiding this comment

EwanC Jun 28, 2023

Choose a reason for hiding this comment

bashbaug left a comment

Choose a reason for hiding this comment