Reduce the Vulkan interop buffer kernel workgroup size to 256 #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `local_size_x = 512` in the shader used in the Vulkan interop tests fails on older hardware because this exceeds the maximum barrier size limit. Changed to 256, which is still a multiple of 32 and 64, and is below the hardware limitations. The tests are not performance tests anyways, so the performance penalty, if any, is acceptable. Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>
bashbaug
approved these changes
Nov 14, 2023
nikhiljnv
approved these changes
Nov 14, 2023
|
Merging as discussed on Memory subgroup call of November 14, 2023. |
kpet
added a commit
to kpet/OpenCL-CTS
that referenced
this pull request
Nov 14, 2023
Vulkan guarantees 128 is always supported. Relates to KhronosGroup#1828 Signed-off-by: Kevin Petit <kevin.petit@arm.com>
kpet
added a commit
to kpet/OpenCL-CTS
that referenced
this pull request
Nov 22, 2023
Vulkan guarantees 128 is always supported. Relates to KhronosGroup#1828 Signed-off-by: Kevin Petit <kevin.petit@arm.com>
nikhiljnv
pushed a commit
that referenced
this pull request
Nov 23, 2023
Vulkan guarantees 128 is always supported. Relates to #1828 Signed-off-by: Kevin Petit <kevin.petit@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
local_size_x = 512in the shader used in the Vulkan interop tests fails on older hardware because this exceeds the maximum barrier size limit.Changed to 256, which is still a multiple of 32 and 64, and is below the hardware limitations. The tests are not performance tests anyways, so the performance penalty, if any, is acceptable.
This fixes issue #1818