Increase the number of work items used by the allocations test #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test uses a fixed number of work items to process very large buffers and images. As devices support more and more memory, this leads to an ever-increasing amount of work done in each work item. This results in some implementations and devices hitting timeout issues. Furthermore, a greater number of work items can provide performance benefits on some devices. Long term, this test should be redesigned to scale the number of threads dynamically as a function of the max allocation size. Signed-off-by: Kevin Petit <kevin.petit@arm.com>
|
The issue this PR helps with has been seen on the following implementations:
|
Jeremy-Kemp
approved these changes
Nov 29, 2023
bashbaug
approved these changes
Dec 1, 2023
|
Merging as agreed in the 2023/12/05 teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test uses a fixed number of work items to process very large buffers and images. As devices support more and more memory, this leads to an ever-increasing amount of work done in each work item. This results in some implementations and devices hitting timeout issues.
Furthermore, a greater number of work items can provide performance benefits on some devices.
Long term, this test should be redesigned to scale the number of threads dynamically as a function of the max allocation size.