Add acquire/release #1899
Merged
Add acquire/release #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshqti
force-pushed
the
fix_cross_context_signals_acquire_release_only
branch
from
a19c521
to
418a299
Compare
nikhiljnv
reviewed
Feb 27, 2024
| nullptr); | ||
| test_error_and_cleanup(err, CLEANUP, | ||
| "Failed to acquire buffers"); | ||
| err = clEnqueueAcquireExternalMemObjectsKHRptr( |
There was a problem hiding this comment.
What if these cl_mems are acquired on cmd_queue2 before kernel that uses these on cmd_queue1 which may make access to these on cmd_queue1 invalid. Also, if cmd_queue1 has already acquired these, then acquiring them on cmd_queue2 without releasing from queue2 may be illegal?
to the enqueue NDRange kernel that uses them.
|
Responded to review comments, and moved acquire/release to precede/follow the clEnqueueNDRangeKernel command that uses the relevant mem-objects. |
|
Merging as discussed in the May 21st teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add acquire/release commands where appropriate. This is related to 1886.