fix bugs in negative command_buffer tests #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CL_INVALID_VALUE from command_queue != NULL should only be returned if the device doesn't support cl_khr_command_buffer_multi_device - some tests enqueued commands with multiple invalid arguments, e.g. clCommandCopyImageToBufferKHR with two images and invalid sync points. AFAIK the order of argument checking is not defined, so multiple errors can be returned for such API calls, but the tests assumed only one error. Fix the tests to be unambiguous.
EwanC
reviewed
May 28, 2024
There was a problem hiding this comment.
LGTM in general, but one comment about calling Skip() in base classes.
As an aside it might be worth checking out a related OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1146 @franz. It's a minor change to make cl_khr_command_buffer_multi_device with clCommandBarrierWithWaitListKHR error behavior consistent with other entry-points entry-point. Since you implement cl_khr_command_buffer_multi_device it would be good to be aware.
test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_svm_mem.cpp
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when calling command buffer APIs, test with
command_queue != NULLshould returnCL_INVALID_VALUEonly if the device doesn't supportcl_khr_command_buffer_multi_device(addedSkip)some tests enqueued commands with multiple invalid arguments, e.g.
clCommandCopyImageToBufferKHRwith two images and invalid sync points. AFAIK the order of argument checking is not defined, so implementation can return any valid error value for such API calls, but the tests assumed only one particular error would be returned. Fix the API calls to be unambiguous.