Command buffer testing fixes #2081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the checks in the test was using an image for the destination of `clCommandCopyImageToBufferKHR()` but this needs to be a buffer. Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com>
The allocated `buffer` is used as an output buffer when copying from `image`, so it needs to be at least as large. Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com>
In the setup of `negative_command_ndrange_kernel_not_support_printf` and `negative_command_ndrange_kernel_with_enqueue_call`, the program was being built without having been first created. Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com>
When there are no properties, the value passed as `param_value_size` is -1, but since the argument is of type `size_t`, this is interpreted as a really big value (and hence not an invalid value, as the test intends). Moreover, if the `command_buffer` was created without properties, then even a size of 0 is large enough to store them. This test requires `command_buffer` to have properties for there to be invalid values for `param_value_size`. Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com>
gorazd-sumkovski-arm
force-pushed
the
command_buffer
branch
from
f1774d1
to
4396d03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.