Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command buffer testing fixes #2081

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Command buffer testing fixes #2081

wants to merge 4 commits into from

Commits on Sep 12, 2024

  1. Fix bug in negative_command_buffer_copy_image_context_not_same 

    One of the checks in the test was using an image for the destination of
`clCommandCopyImageToBufferKHR()` but this needs to be a buffer.

Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com>
    @gorazd-sumkovski-arm
    gorazd-sumkovski-arm committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    274a7a9 View commit details
    Browse the repository at this point in the history

  2. Increase size of buffer in CommandBufferCopyBaseTest 

    The allocated `buffer` is used as an output buffer when copying from
`image`, so it needs to be at least as large.

Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com>
    @gorazd-sumkovski-arm
    gorazd-sumkovski-arm committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d2a39f6 View commit details
    Browse the repository at this point in the history

  3. Fix setup in command buffer tests 

    In the setup of `negative_command_ndrange_kernel_not_support_printf` and
`negative_command_ndrange_kernel_with_enqueue_call`, the program was
being built without having been first created.

Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com>
    @gorazd-sumkovski-arm
    gorazd-sumkovski-arm committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6b90977 View commit details
    Browse the repository at this point in the history

  4. Skip RunPropArrayInfoTest if there are no properties 

    When there are no properties, the value passed as `param_value_size` is
-1, but since the argument is of type `size_t`, this is interpreted as a
really big value (and hence not an invalid value, as the test intends).

Moreover, if the `command_buffer` was created without properties, then
even a size of 0 is large enough to store them. This test requires
`command_buffer` to have properties for there to be invalid values for
`param_value_size`.

Signed-off-by: Gorazd Sumkovski <gorazd.sumkovski@arm.com>
    @gorazd-sumkovski-arm
    gorazd-sumkovski-arm committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    4396d03 View commit details
    Browse the repository at this point in the history