Use array for clUpdateMutableCommandsKHR. #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
added
the
cl_khr_command_buffer
This was referenced Jan 16, 2024
EwanC
commented
Jan 16, 2024
EwanC
commented
Jan 16, 2024
EwanC
added a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Jan 17, 2024
Implementation change to prototype specification changes proposed in KhronosGroup/OpenCL-Docs#1041 Uses OpenCL-Docs and OpenCL-Header changes from * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245
EwanC
force-pushed
the
array_command_update
branch
from
1adf2ce
to
8b0b63a
Compare
EwanC
added a commit
to EwanC/OpenCL-Docs
that referenced
this pull request
Feb 21, 2024
Draft of `cl_khr_command_buffer_mutable_memory_commands` based ontop of KhronosGroup#1045 which updates `clUpdateMutableCommandsKHR` to pass configs by an array rather than linked list. The goal of this extension is to be able to update the parameters to memory operation commands in a command-buffer after the command-buffer has been finalized using the `clUpdateMutableCommandsKHR` entry-point defined by `cl_khr_command_buffer_mutable_dispatch`.
EwanC
added a commit
to EwanC/OpenCL-Docs
that referenced
this pull request
Feb 21, 2024
Draft of `cl_khr_command_buffer_mutable_memory_commands` based ontop of KhronosGroup#1045 which updates `clUpdateMutableCommandsKHR` to pass configs by an array rather than linked list. The goal of this extension is to be able to update the parameters to memory operation commands in a command-buffer after the command-buffer has been finalized using the `clUpdateMutableCommandsKHR` entry-point defined by `cl_khr_command_buffer_mutable_dispatch`.
EwanC
force-pushed
the
array_command_update
branch
from
8b0b63a
to
c3b369c
Compare
EwanC
force-pushed
the
array_command_update
branch
from
c3b369c
to
6662265
Compare
|
I've rebased this change after #950 merged, however I'm still getting familiar with how the spec looks now. So changing this PR back to draft until I double check I'm happy with how everything looks. EDIT - taken this out of draft again, as I'm good with how it looks now. |
EwanC
force-pushed
the
array_command_update
branch
from
6662265
to
52f8a28
Compare
EwanC
force-pushed
the
array_command_update
branch
2 times, most recently
from
62e7b7d
to
2673582
Compare
EwanC
added a commit
to EwanC/OpenCL-Docs
that referenced
this pull request
Mar 28, 2024
Draft of `cl_khr_command_buffer_mutable_memory_commands` based ontop of KhronosGroup#1045 which updates `clUpdateMutableCommandsKHR` to pass configs by an array rather than linked list. The goal of this extension is to be able to update the parameters to memory operation commands in a command-buffer after the command-buffer has been finalized using the `clUpdateMutableCommandsKHR` entry-point defined by `cl_khr_command_buffer_mutable_dispatch`.
EwanC
added a commit
to EwanC/OpenCL-Docs
that referenced
this pull request
Mar 29, 2024
Draft of `cl_khr_command_buffer_mutable_memory_commands` based ontop of KhronosGroup#1045 which updates `clUpdateMutableCommandsKHR` to pass configs by an array rather than linked list. The goal of this extension is to be able to update the parameters to memory operation commands in a command-buffer after the command-buffer has been finalized using the `clUpdateMutableCommandsKHR` entry-point defined by `cl_khr_command_buffer_mutable_dispatch`.
Proposal to pass the update configs to `clUpdateMutableCommandsKHR` as an array, rather than pointer changed linked list. See KhronosGroup#1041 for motivation.
EwanC
force-pushed
the
array_command_update
branch
from
2673582
to
a319d88
Compare
EwanC
added a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Jun 19, 2024
CTS change to reflect proposed change from KhronosGroup/OpenCL-Docs#1041 Taking advantage of the extension version macros to avoid breaking existing implementations immediately. This reflects PRs: * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245
EwanC
added a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Jun 19, 2024
CTS change to reflect proposed change from KhronosGroup/OpenCL-Docs#1041 Taking advantage of the extension version macros to avoid breaking existing implementations immediately. This reflects PRs: * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245
EwanC
added a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Jun 19, 2024
Implementation change to prototype specification changes proposed in KhronosGroup/OpenCL-Docs#1041 Uses OpenCL changes from * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245 * KhronosGroup/OpenCL-CTS#1984
aharon-abramson
approved these changes
Jun 20, 2024
|
Discussed in the July 9th teleconference. We set a deadline for two weeks to merge (July 23rd). |
kpet
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Thanks for proposing this change! Happy with the direction. I have not turned every stone and so might have missed points of detail but I suggest we prioritise aligning all components to this proposal to enable forward progress and fix any minor issues on top.
Comment on lines
+15730
to
+15734
| If _configs_ is non-`NULL`, then for any {cl_mutable_dispatch_config_khr_TYPE} | ||
| element of the array the errors defined by {clEnqueueNDRangeKernel}, | ||
| {clSetKernelExecInfo}, {clSetKernelArg}, and {clSetKernelArgSVMPointer} are | ||
| returned by {clUpdateMutableCommandsKHR} if any of the struct elements are set | ||
| to an invalid value. Additionally, the following errors are returned if any |
There was a problem hiding this comment.
I think we should try to improve how this is described so we make the list of errors that may be returned a bit clearer. This is not something that this PR changes so I'm prefectly fine with capturing an issue that we'd look at separately.
There was a problem hiding this comment.
Creating an issue makes sense, is there any particular way you imagine the improvement looking? e.g. Being more explicit about the errors rather than referencing core API entry-points, or just making the layout of the existing information more readable.
There was a problem hiding this comment.
The first idea that came to mind was to categorise errors in the description of those commands such that we could refer to the categories here but I have not though enough about this to really have good input or opinions.
There was a problem hiding this comment.
Created issue #1209 to track this
|
Merging as discussed in the July 16th teleconference. |
EwanC
added a commit
to EwanC/OpenCL-Headers
that referenced
this pull request
Jul 19, 2024
Proposal to pass the update configs to `clUpdateMutableCommandsKHR` as an array, rather than pointer changed linked list. See KhronosGroup/OpenCL-Docs#1041 for motivation and KhronosGroup/OpenCL-Docs#1045 for OpenCL-Docs PR.
EwanC
added a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Jul 19, 2024
Implementation change to prototype specification changes proposed in KhronosGroup/OpenCL-Docs#1041 Uses OpenCL changes from * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245 * KhronosGroup/OpenCL-CTS#1984
EwanC
added a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Jul 19, 2024
Implementation change to prototype specification changes proposed in KhronosGroup/OpenCL-Docs#1041 Uses OpenCL changes from * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245 * KhronosGroup/OpenCL-CTS#1984
EwanC
added a commit
to EwanC/oneapi-construction-kit
that referenced
this pull request
Jul 19, 2024
Implementation change to prototype specification changes proposed in KhronosGroup/OpenCL-Docs#1041 Uses OpenCL changes from * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245 * KhronosGroup/OpenCL-CTS#1984
EwanC
added a commit
to EwanC/OpenCL-CLHPP
that referenced
this pull request
Jul 31, 2024
In OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1045 the API for `cl_khr_command_buffer_mutable_dispatch` API `clUpdateMutableCommandsKHR` changed in a breaking way. When the headers update OpenCL-Headers PR KhronosGroup/OpenCL-Headers#245 the bindings will break if they are not updated to reflect this change. Bindings updated in this PR to pass to arrays of templated length to the C++ method. The underlying `.data()` pointers of these parameters can be passed through to the OpenCL API.
EwanC
added a commit
to EwanC/OpenCL-CLHPP
that referenced
this pull request
Aug 1, 2024
In OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1045 the API for `cl_khr_command_buffer_mutable_dispatch` API `clUpdateMutableCommandsKHR` changed in a breaking way. When the headers update OpenCL-Headers PR KhronosGroup/OpenCL-Headers#245 the bindings will break if they are not updated to reflect this change. Bindings updated in this PR to pass to arrays of templated length to the C++ method. The underlying `.data()` pointers of these parameters can be passed through to the OpenCL API.
EwanC
added a commit
to EwanC/OpenCL-CTS
that referenced
this pull request
Sep 5, 2024
CTS change to reflect proposed change from KhronosGroup/OpenCL-Docs#1041 Taking advantage of the extension version macros to avoid breaking existing implementations immediately. This reflects PRs: * KhronosGroup/OpenCL-Docs#1045 * KhronosGroup/OpenCL-Headers#245
bashbaug
pushed a commit
to KhronosGroup/OpenCL-Headers
that referenced
this pull request
Sep 6, 2024
Proposal to pass the update configs to `clUpdateMutableCommandsKHR` as an array, rather than pointer changed linked list. See KhronosGroup/OpenCL-Docs#1041 for motivation and KhronosGroup/OpenCL-Docs#1045 for OpenCL-Docs PR.
bashbaug
pushed a commit
to KhronosGroup/OpenCL-CLHPP
that referenced
this pull request
Sep 6, 2024
In OpenCL-Docs PR KhronosGroup/OpenCL-Docs#1045 the API for `cl_khr_command_buffer_mutable_dispatch` API `clUpdateMutableCommandsKHR` changed in a breaking way. When the headers update OpenCL-Headers PR KhronosGroup/OpenCL-Headers#245 the bindings will break if they are not updated to reflect this change. Bindings updated in this PR to pass to arrays of templated length to the C++ method. The underlying `.data()` pointers of these parameters can be passed through to the OpenCL API.
bashbaug
pushed a commit
to KhronosGroup/OpenCL-CTS
that referenced
this pull request
Sep 6, 2024
CTS changes to reflect the spec changes merged in KhronosGroup/OpenCL-Docs#1045 and requires header updates from KhronosGroup/OpenCL-Headers#245 Tested using OCK implementation from codeplaysoftware/oneapi-construction-kit#501
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to pass the update configs to
clUpdateMutableCommandsKHRas an array, rather than pointer chained linked list.See #1041 for motivation.