-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CL_INVALID_CONTEXT command-buffer error definitions #1149
Conversation
See issue KhronosGroup#1147 documenting that the error specification for `CL_INVALID_CONTEXT` doesn't take into account the variation when `cl_khr_command_buffer_multi_device` is enabled. Doing this change also picked up that the error wording for `clCommandSVMMemcpyKHR` and `clCommandSVMMemFillKHR` referenced the _kernel_ parameter which doesn't exist.
* Remove extraneous `cl_khr_command_buffer_multi_device` precondition from error wording. * Change "enabled" terminology to "supported" with regards to extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Could of follow-on questions:
Thanks! |
That's the intention, i've added "Closes #1147" to the PR description, which should be one of the magic words for GitHub to do this automatically.
I think this PR can wait because it's specifying relatively edge case behaviour, so I don't think waiting a week or so will affect anyone. The negative testing PRs already assume the behaviour in this PR and only stress the wording outside of the multi-device guards, this is because we've yet to do any cl_khr_command_buffer_multi_device testing so introducing it as part of negative testing even without this spec change would be a fair amount of scope increase to the task. |
Merging as discussed in the July 16th teleconference. |
See issue #1147 documenting that the error specification for
CL_INVALID_CONTEXT
doesn't take into account the variation whencl_khr_command_buffer_multi_device
is enabled.Doing this change also picked up that the error wording for
clCommandSVMMemcpyKHR
andclCommandSVMMemFillKHR
referenced the kernel parameter which doesn't exist.Closes #1147