Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CL_INVALID_CONTEXT command-buffer error definitions #1149

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Fix CL_INVALID_CONTEXT command-buffer error definitions #1149

merged 2 commits into from
Jul 16, 2024

Commits on May 22, 2024

  1. Fix CL_INVALID_CONTEXT command-buffer error definitions 

    See issue KhronosGroup#1147
documenting that the error specification for `CL_INVALID_CONTEXT`
doesn't take into account the variation when
`cl_khr_command_buffer_multi_device` is enabled.

Doing this change also picked up that the error wording for
`clCommandSVMMemcpyKHR` and `clCommandSVMMemFillKHR` referenced
the _kernel_ parameter which doesn't exist.
    @EwanC
    EwanC committed May 22, 2024
    Configuration menu
    Copy the full SHA
    84129bf View commit details
    Browse the repository at this point in the history

  2. Address review feedback 

    * Remove extraneous `cl_khr_command_buffer_multi_device` precondition
  from error wording.
* Change "enabled" terminology to "supported" with regards to
  extensions.
    @EwanC
    EwanC committed May 22, 2024
    Configuration menu
    Copy the full SHA
    fcd0660 View commit details
    Browse the repository at this point in the history