Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate OpenCL C feature dictionary #1212

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Generate OpenCL C feature dictionary #1212

merged 3 commits into from
Aug 13, 2024

Conversation

kpet
Copy link
Contributor

@kpet kpet commented Jul 17, 2024

Features are stored in a text file for now. Ultimately, we probably want to use the XML registry for this.

Generation script taken from #1174 with a few modifications.

Contributes to #1166.

Change-Id: Ie2c14148d75457030aa1a97cf601daba2c007397

@kpet
Generate OpenCL C feature dictionary
8275f3d 
Features are stored in a text file for now. Ultimately, we probably
want to use the XML registry for this.

Generation script taken from KhronosGroup#1174 with a few modifications.

Contributes to KhronosGroup#1166.

Signed-off-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
Signed-off-by: Kevin Petit <kevin.petit@arm.com>
Change-Id: Ie2c14148d75457030aa1a97cf601daba2c007397
@kpet kpet requested a review from bashbaug July 17, 2024 11:34
bashbaug
bashbaug reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement!

Once this goes in I might look at generalizing it for other uses in the OpenCL C spec. For example, it might be useful to have dictionaries for long built-in function names, to fix #1214.

c/features.txt Outdated Show resolved Hide resolved
scripts/gen_c_feature_dictionary.py Outdated Show resolved Hide resolved
kpet and others added 2 commits August 9, 2024 11:06
@kpet @bashbaug
Update scripts/gen_c_feature_dictionary.py
75c8ba4 
Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
@kpet
define __opencl_c_<feature_name> outside of the list of features
40ad531 
Signed-off-by: Kevin Petit <kevin.petit@arm.com>
Change-Id: I8e0947c30775338dd70803d09c7059d340e86f5a
bashbaug
bashbaug approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bashbaug bashbaug merged commit 47dd749 into KhronosGroup:main Aug 13, 2024
2 checks passed
@kpet kpet deleted the generate-c-feature-dict branch August 14, 2024 14:10
@bashbaug bashbaug mentioned this pull request Aug 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashbaug bashbaug bashbaug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpet @bashbaug