Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify the CL_INVALID_COMMAND_QUEUE behavior for semaphore signals and waits #1256

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Sep 9, 2024

Fixes #1217

Unifies the CL_INVALID_COMMAND_QUEUE behavior for clEnqueueSignalSemaphoresKHR and clEnqueueWaitSemaphoresKHR.

Also bumps the patch revision, as described in the suggested resolution.

Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, change is one of the two possible resolutions on the ticket, I see no problem with taking this one.

@bashbaug bashbaug merged commit 443d25b into KhronosGroup:main Sep 12, 2024
2 checks passed
@bashbaug bashbaug deleted the semaphore-wait-error-condition branch September 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec of negative result for waiting on and signaling semaphores differs
2 participants