Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify clGetSemaphoreHandleForTypeKHR is part of cl_khr_external_semaphore #1257

Merged
merged 1 commit into from
Sep 12, 2024
Merged

clarify clGetSemaphoreHandleForTypeKHR is part of cl_khr_external_semaphore #1257

merged 1 commit into from
Sep 12, 2024

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Sep 9, 2024

fixes #1191

  • Puts clGetSemaphoreHandleForTypeKHR in the summary for cl_khr_external_semaphore, not cl_khr_external_semaphore_sync_fd.
  • Adds the version note for clGetSemaphoreHandleForTypeKHR.

kpet
kpet approved these changes Sep 9, 2024
View reviewed changes
api/opencl_runtime_layer.asciidoc
@@ -12940,6 +12940,7 @@ Please refer to handle specific documentation for more details on transference r
To export an external handle from a semaphore, call the function

include::{generated}/api/protos/clGetSemaphoreHandleForTypeKHR.txt[]
include::{generated}/api/version-notes/clGetSemaphoreHandleForTypeKHR.asciidoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether we should include the version notes in the generated proto snippet. It seems we mostly (always?) include them right after the proto snippet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly can't remember if there was a reason I put them in a separate file, rather than adding them to the proto.

alycm
alycm approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

api/opencl_runtime_layer.asciidoc
@@ -12940,6 +12940,7 @@ Please refer to handle specific documentation for more details on transference r
To export an external handle from a semaphore, call the function

include::{generated}/api/protos/clGetSemaphoreHandleForTypeKHR.txt[]
include::{generated}/api/version-notes/clGetSemaphoreHandleForTypeKHR.asciidoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly can't remember if there was a reason I put them in a separate file, rather than adding them to the proto.

@bashbaug bashbaug merged commit fe6b158 into KhronosGroup:main Sep 12, 2024
2 checks passed
@bashbaug bashbaug deleted the clarify-clGetSemaphoreHandleForTypeKHR branch September 12, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alycm alycm alycm approved these changes

@kpet kpet kpet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typo in description for clReImportSemaphoreSyncFdKHR
3 participants
@bashbaug @kpet @alycm