Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify clGetSemaphoreHandleForTypeKHR is part of cl_khr_external_semaphore #1257

Merged
merged 1 commit into from
Sep 12, 2024
Merged

clarify clGetSemaphoreHandleForTypeKHR is part of cl_khr_external_semaphore #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/cl_khr_external_semaphore.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ The layered extensions {cl_khr_external_semaphore_opaque_fd_EXT},
{cl_khr_external_semaphore_win32_EXT} define specific external semaphores
that may be imported into or exported from OpenCL.

=== New Commands

* {clGetSemaphoreHandleForTypeKHR}

=== New Types

* {cl_external_semaphore_handle_type_khr_TYPE}
Expand Down
1 change: 0 additions & 1 deletion api/cl_khr_external_semaphore_sync_fd.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ external semaphore using the APIs introduced by

=== New Commands

* {clGetSemaphoreHandleForTypeKHR}
* {clReImportSemaphoreSyncFdKHR}

=== New Types
Expand Down
1 change: 1 addition & 0 deletions api/opencl_runtime_layer.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12940,6 +12940,7 @@ Please refer to handle specific documentation for more details on transference r
To export an external handle from a semaphore, call the function

include::{generated}/api/protos/clGetSemaphoreHandleForTypeKHR.txt[]
include::{generated}/api/version-notes/clGetSemaphoreHandleForTypeKHR.asciidoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether we should include the version notes in the generated proto snippet. It seems we mostly (always?) include them right after the proto snippet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly can't remember if there was a reason I put them in a separate file, rather than adding them to the proto.


* _sema_object_ specifies a valid semaphore object with exportable
properties.
Expand Down