Refactor translation and reverse translation of PipelineEnableINTEL for loops and functions #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenxue-intel
force-pushed
the
KernelAndLoopMetadataRenaming
branch
from
c24ad6a
to
e20ae37
Compare
bowenxue-intel
force-pushed
the
KernelAndLoopMetadataRenaming
branch
from
e20ae37
to
c0f05bf
Compare
MrSidims
approved these changes
Oct 9, 2023
|
May be merge was a bit hasty, what will happen with llvm.loop.intel.pipelining.enable/disable ? |
|
Nothing is being changed for the loop metadata, since there are both enable and disable loop attributes and llvm.loop.intel.pipelining.enable is being generated for both of them, so they are already unified and no change is needed |
|
Updated PR description body to reflect the actual changes that went in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor SPIRVWriter to accept !pipeline_kernel instead of !disable_loop_pipelining for function metadata.
Refactor SPIRVReader to emit !pipeline_kernel instead of !disable_loop_pipelining for function metadata.
Relevant/Related intel/llvm PR: intel/llvm#11372