Revert "[PD] Revert 316506f, back to shell algo for some helix cases … #117
CI_master.yml
on: push
Prepare
/
Prepare
4s
MacOS_13_Conda_Apple
/
Build
50m 35s
Ubuntu_20-04
/
Build
1h 32m
Ubuntu_22-04_Conda
/
Build
1h 40m
Windows
/
Build
2h 6m
Lint
/
Lint
3m 23s
Ubuntu_22-04_Conda_Qt6
/
Build
1h 46m
WrapUp
/
WrapUp
5s
Annotations
2 errors and 71 warnings
Lint / Lint
Process completed with exit code 1.
|
Lint / Lint
Process completed with exit code 1.
|
Lint / Lint:
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L1
would reformat src/Mod/PartDesign/PartDesignTests/TestHelix.py
|
Lint / Lint:
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L116
Line too long (132/100) (line-too-long)
|
Lint / Lint:
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L152
Line too long (107/100) (line-too-long)
|
Lint / Lint:
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L168
Line too long (132/100) (line-too-long)
|
Lint / Lint:
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L181
Trailing newlines (trailing-newlines)
|
Lint / Lint:
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L1
Missing module docstring (missing-module-docstring)
|
Lint / Lint:
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L32
String statement has no effect (pointless-string-statement)
|
Lint / Lint:
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L38
Missing function or method docstring (missing-function-docstring)
|
Lint / Lint:
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L144
Unused variable 'l1' (unused-variable)
|
Lint / Lint:
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L144
Unused variable 'l2' (unused-variable)
|
Lint / Lint:
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L144
Unused variable 'l4' (unused-variable)
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L46
Found C system header after other header. Should be: FeatureHelix.h, c system, c++ system, other. [build/include_order] [4]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L47
Found C system header after other header. Should be: FeatureHelix.h, c system, c++ system, other. [build/include_order] [4]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L48
Found C system header after other header. Should be: FeatureHelix.h, c system, c++ system, other. [build/include_order] [4]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L49
Found C system header after other header. Should be: FeatureHelix.h, c system, c++ system, other. [build/include_order] [4]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L51
Found C system header after other header. Should be: FeatureHelix.h, c system, c++ system, other. [build/include_order] [4]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L52
Found C system header after other header. Should be: FeatureHelix.h, c system, c++ system, other. [build/include_order] [4]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L56
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L58
Lines should be <= 120 characters long [whitespace/line_length] [2]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L67
{ should almost always be at the end of the previous line [whitespace/braces] [4]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L78
Use int16/int64/etc, rather than the C type long [runtime/int] [4]
|
Lint / Lint
NCollection_ListNode has copy-ctor, copy-assignment but not dtor [-Wclazy-rule-of-three]
|
Lint / Lint
Pass small and trivially-copyable type by value (const class NCollection_BaseList::Iterator &) [-Wclazy-function-args-by-value]
|
Lint / Lint
Pass small and trivially-copyable type by value (const class NCollection_BaseList::Iterator &) [-Wclazy-function-args-by-value]
|
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Lint / Lint
Pass small and trivially-copyable type by value (const class gp_XY &) [-Wclazy-function-args-by-value]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L58
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L81
do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L82
10.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L84
30.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L86
3.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L117
statement should be inside braces [readability-braces-around-statements]
|
Lint / Lint:
src/Mod/PartDesign/App/FeatureHelix.cpp#L122
function 'execute' has cognitive complexity of 66 (threshold 25) [readability-function-cognitive-complexity]
|
Lint / Lint
note: +1, including nesting penalty of 0, nesting level increased to 1
|
Lint / Lint
note: +2, including nesting penalty of 1, nesting level increased to 2
|
Lint / Lint
note: +2, including nesting penalty of 1, nesting level increased to 2
|
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(352): conda version: 24.3.0
INFO conda.conda_libmamba_solver.solver:_log_info(353): conda-libmamba-solver version: 24.1.0
|
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(354): libmambapy version: 1.5.8
|
MacOS_13_Conda_Apple / Build
INFO conda.conda_libmamba_solver.solver:_log_info(355): Target prefix: '/Users/runner/work/FreeCAD/FreeCAD/.conda/freecad'
INFO conda.conda_libmamba_solver.solver:_log_info(356): Command: ['/Users/runner/miniconda3/condabin/mamba', 'update', '--prefix', '.conda/freecad', '--file', 'conda/conda-env.yaml']
|
MacOS_13_Conda_Apple / Build
info libmamba Reading repodata.json file "/var/folders/zn/hj183dg15s713b47j2wlhwzw0000gn/T/tmp5dff2p29.json" for repo installed
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 0 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Darwin/23.5.0 OSX/14.5 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches 5fef5ecd58e910a9… → 5fef5ecd58e910a9…
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 715638 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Darwin/23.5.0 OSX/14.5 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches 63cd651a378e2a3f… → 63cd651a378e2a3f…
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 2050706 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Darwin/23.5.0 OSX/14.5 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
MacOS_13_Conda_Apple / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches c25462d7872987b0… → c25462d7872987b0…
|
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(352): conda version: 24.3.0
INFO conda.conda_libmamba_solver.solver:_log_info(353): conda-libmamba-solver version: 24.1.0
|
Ubuntu_22-04_Conda / Build
INFO conda.conda_libmamba_solver.solver:_log_info(354): libmambapy version: 1.5.8
INFO conda.conda_libmamba_solver.solver:_log_info(355): Target prefix: '/home/runner/work/FreeCAD/FreeCAD/.conda/freecad'
INFO conda.conda_libmamba_solver.solver:_log_info(356): Command: ['/home/runner/miniconda3/condabin/mamba', 'update', '--prefix', '.conda/freecad', '--file', 'conda/conda-env.yaml']
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 715638 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches 63cd651a378e2a3f… → 63cd651a378e2a3f…
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 1612142 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches c9003a175bed204f… → c9003a175bed204f…
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 2050706 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches c25462d7872987b0… → c25462d7872987b0…
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 6305328 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches 566afa707868e2b8… → 566afa707868e2b8…
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(352): conda version: 24.3.0
INFO conda.conda_libmamba_solver.solver:_log_info(353): conda-libmamba-solver version: 24.1.0
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.conda_libmamba_solver.solver:_log_info(354): libmambapy version: 1.5.8
INFO conda.conda_libmamba_solver.solver:_log_info(355): Target prefix: '/home/runner/work/FreeCAD/FreeCAD/.conda/freecad'
INFO conda.conda_libmamba_solver.solver:_log_info(356): Command: ['/home/runner/miniconda3/condabin/mamba', 'update', '--prefix', '.conda/freecad', '--file', 'conda/conda-env-qt6.yaml']
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 715638 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches 63cd651a378e2a3f… → 63cd651a378e2a3f…
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 1612142 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches c9003a175bed204f… → c9003a175bed204f…
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 2050706 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches c25462d7872987b0… → c25462d7872987b0…
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:download_and_hash(264): Download 6305328 bytes {'User-Agent': 'conda/24.3.0 requests/2.31.0 CPython/3.10.14 Linux/6.5.0-1025-azure ubuntu/22.04.4 glibc/2.35 solver/libmamba conda-libmamba-solver/24.1.0 libmambapy/1.5.8', 'Accept-Encoding': 'gzip, deflate, br, zstd', 'Accept': '*/*', 'Connection': 'keep-alive'}
|
Ubuntu_22-04_Conda_Qt6 / Build
INFO conda.gateways.repodata.jlap.fetch:request_url_jlap_state(431): Apply 0 patches 566afa707868e2b8… → 566afa707868e2b8…
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
Lint-10280136296-Logs
|
26.4 KB |
|
MacOS_13_Conda_Apple-10280136296-Logs
|
44.7 KB |
|
Prepare-10280136296-Logs
|
4.57 KB |
|
Ubuntu_20-04-10280136296-Logs
|
179 KB |
|
Ubuntu_22-04_Conda-10280136296-Logs
|
244 KB |
|
Ubuntu_22-04_Conda-Qt6-10280136296-Logs
|
244 KB |
|
Ubuntu_22-04_Conda-Qt6-10280136296-report.md
|
4.03 KB |
|
Windows-10280136296-Logs
|
2.5 MB |
|