Revert "[PD] Revert 316506f, back to shell algo for some helix cases … #117
Annotations
2 errors and 41 warnings
|
|
|
|
|
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L1
would reformat src/Mod/PartDesign/PartDesignTests/TestHelix.py
|
|
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L116
Line too long (132/100) (line-too-long)
|
|
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L152
Line too long (107/100) (line-too-long)
|
|
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L168
Line too long (132/100) (line-too-long)
|
|
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L181
Trailing newlines (trailing-newlines)
|
|
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L1
Missing module docstring (missing-module-docstring)
|
|
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L32
String statement has no effect (pointless-string-statement)
|
|
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L38
Missing function or method docstring (missing-function-docstring)
|
|
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L144
Unused variable 'l1' (unused-variable)
|
|
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L144
Unused variable 'l2' (unused-variable)
|
|
src/Mod/PartDesign/PartDesignTests/TestHelix.py#L144
Unused variable 'l4' (unused-variable)
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L46
Found C system header after other header. Should be: FeatureHelix.h, c system, c++ system, other. [build/include_order] [4]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L47
Found C system header after other header. Should be: FeatureHelix.h, c system, c++ system, other. [build/include_order] [4]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L48
Found C system header after other header. Should be: FeatureHelix.h, c system, c++ system, other. [build/include_order] [4]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L49
Found C system header after other header. Should be: FeatureHelix.h, c system, c++ system, other. [build/include_order] [4]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L51
Found C system header after other header. Should be: FeatureHelix.h, c system, c++ system, other. [build/include_order] [4]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L52
Found C system header after other header. Should be: FeatureHelix.h, c system, c++ system, other. [build/include_order] [4]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L56
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L58
Lines should be <= 120 characters long [whitespace/line_length] [2]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L67
{ should almost always be at the end of the previous line [whitespace/braces] [4]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L78
Use int16/int64/etc, rather than the C type long [runtime/int] [4]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L58
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L81
do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L82
10.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L84
30.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L86
3.0 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L117
statement should be inside braces [readability-braces-around-statements]
|
|
src/Mod/PartDesign/App/FeatureHelix.cpp#L122
function 'execute' has cognitive complexity of 66 (threshold 25) [readability-function-cognitive-complexity]
|
|
|
|
|
|
|
This job succeeded
Loading