remove deprecated devcontainer configuration and scripts #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the dev container setup, primarily focusing on simplifying the configuration and removing unused components. It uses the new image that is generated by #25, so #25 needs to be deployed first.
The most important changes include the removal of the Dockerfile, renaming and modifying the devcontainer.json file, and cleaning up the installation script and repository references.
Dev container setup simplification:
.devcontainer/Dockerfile: Removed the Dockerfile, which included the base image setup, user configuration, and installation of dependencies..devcontainer/devcontainer.json: Renamed from.devcontainer/cuda-opengl/devcontainer.jsonand modified to use a different image without CUDA and OpenGL.Installation script cleanup:
.devcontainer/install.sh: Removed the installation script that set up ROS dependencies and built the workspace.Repository references cleanup:
.devcontainer/lcas.repos: Removed the repository references forlimo_ros2.CI workflow cleanup:
.github/workflows/dev-container.yml: Removed the CI workflow configuration for building the dev container.