Transports/CommManager: fix several serious and continuous leaks #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Messages were being cloned (new) without being properly released. - Avoided cloning where possible - Release resources - Make sure order of deleting pointers and erasing elements from container is correct
josebraga
force-pushed
the
bugfix/commmanager-serious-leak
branch
from
9d8bdbf
to
73d67d6
Compare
xBogas
pushed a commit
to xBogas/dune
that referenced
this pull request
May 16, 2024
…-leak Transports/CommManager: fix several serious and continuous leaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages were being cloned (new) without being properly released.
container is correct