Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Updates #1536

Merged
merged 70 commits into from
Jul 24, 2024
Merged

Package Updates #1536

merged 70 commits into from
Jul 24, 2024

Conversation

labkey-nicka
Copy link
Contributor

@labkey-nicka labkey-nicka commented Jul 23, 2024

Rationale

Package updates for @labkey/build, @labkey/test, @labkey/components, @labkey/eslint-config-base and @labkey/eslint-config-react. The most notable change is switching the default target to ES2021 from ES6. This changes the generated output code of our applications to default to browser native implementations for ES-features up through ES2021. Here is a nice summary of the features and their adoption rate in browsers. The most recent version of all major browser have supported all of these features for awhile now.

Additionally, these package updates are aligned with NodeJS v20 which we're updating as a part of these changes.

Related Pull Requests

Changes

@labkey/build

  • Package updates
  • Update tsconfig.json to "target": "ES2021" and "lib": ["ES2021", "DOM", "DOM.Iterable"]

@labkey/components

  • Package updates
  • Refactor out the testMode prop from DomainForm
  • Fix-up a number of unit tests to no longer issue runtime errors

@labkey/eslint-config-base

  • Package updates
  • Did not perform major upgrade of ESLint to v9.x as this will require a significant change to how our linting configuration is declared. See the migration guide.

@labkey/eslint-config-react

  • Package updates

@labkey/test

  • Package updates
  • Convert build from yarn to npm

Copy link
Contributor

@cnathe cnathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see the testMode removed!
And there was still a yarn.lock file? wow!

@labkey-nicka labkey-nicka force-pushed the fb_package_updates_0724 branch from 6aa160c to f152c01 Compare July 24, 2024 18:21
@labkey-nicka labkey-nicka merged commit 62cbde8 into develop Jul 24, 2024
2 checks passed
@labkey-nicka labkey-nicka deleted the fb_package_updates_0724 branch July 24, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants