-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package Updates #1536
Merged
Merged
Package Updates #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2024
cnathe
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to see the testMode
removed!
And there was still a yarn.lock file? wow!
labkey-nicka
force-pushed
the
fb_package_updates_0724
branch
from
July 23, 2024 21:22
863d00a
to
6aa160c
Compare
- rimraf not 6.x yet since that requires node v20+
- only applicable with yarn - we can use "overrides" if we end up needing this
labkey-nicka
force-pushed
the
fb_package_updates_0724
branch
from
July 24, 2024 18:21
6aa160c
to
f152c01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Package updates for
@labkey/build
,@labkey/test
,@labkey/components
,@labkey/eslint-config-base
and@labkey/eslint-config-react
. The most notable change is switching the default target to ES2021 from ES6. This changes the generated output code of our applications to default to browser native implementations for ES-features up through ES2021. Here is a nice summary of the features and their adoption rate in browsers. The most recent version of all major browser have supported all of these features for awhile now.Additionally, these package updates are aligned with NodeJS v20 which we're updating as a part of these changes.
Related Pull Requests
Changes
@labkey/build
tsconfig.json
to"target": "ES2021"
and"lib": ["ES2021", "DOM", "DOM.Iterable"]
@labkey/components
testMode
prop fromDomainForm
@labkey/eslint-config-base
@labkey/eslint-config-react
@labkey/test