Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nbgl add use case choice #173

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Nbgl add use case choice #173

merged 4 commits into from
Jul 26, 2024

Conversation

agrojean-ledger
Copy link
Contributor

@agrojean-ledger agrojean-ledger commented Jul 26, 2024 •
edited
Loading

  • Add "choice" use case in NBGL module.
  • Implement warning screens for reviewing transactions in "blind" mode, directly into the NBGL module (for NbglReview and NbglStreamingReview when blind() is called before show())
  • Code cleanup, remove the name of the crate ledger_secure_sdk_sys in NBGL when calling stuff from it, it's useless as we import everything from it.

yogh333
yogh333 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@yogh333 yogh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@agrojean-ledger agrojean-ledger mentioned this pull request Jul 26, 2024
Merged
3 tasks
@agrojean-ledger agrojean-ledger merged commit f8afb3b into master Jul 26, 2024
43 checks passed
@agrojean-ledger agrojean-ledger deleted the nbgl-add-use-case-choice branch July 26, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogh333 yogh333 yogh333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agrojean-ledger @yogh333