Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbgl: Add force_page_start to nbgl_layoutTagValue_t #520

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

xchapron-ledger
Copy link
Contributor

Description

nbgl: Add force_page_start to nbgl_layoutTagValue_t
This allow to force displaying a tag/value pair in a new page, hence allowing to display pairs in group when relevant.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

This allow to force displaying a tag/value pair in a new page, hence
allowing to display pairs in group when relevant.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9df153) 60.42% compared to head (9c844af) 60.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #520   +/-   ##
=======================================
  Coverage   60.42%   60.42%           
=======================================
  Files          12       12           
  Lines        1660     1660           
=======================================
  Hits         1003     1003           
  Misses        657      657           
Flag Coverage Δ
unittests 60.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xchapron-ledger xchapron-ledger merged commit ede8dac into master Jan 31, 2024
161 checks passed
@xchapron-ledger xchapron-ledger deleted the xch/nbgl-review-page-break branch January 31, 2024 14:45
@xchapron-ledger xchapron-ledger mentioned this pull request Feb 20, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants