This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Update tests for interop cross chain updates #9138
Merged
ishantiw
merged 11 commits into
release/6.1.0
from
8193-unit-test-review-interop-ccu-commands
Nov 23, 2023
Merged
Update tests for interop cross chain updates #9138
ishantiw
merged 11 commits into
release/6.1.0
from
8193-unit-test-review-interop-ccu-commands
Nov 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/6.1.0 #9138 +/- ##
=================================================
- Coverage 84.35% 84.35% -0.01%
=================================================
Files 655 655
Lines 24113 24113
Branches 3497 3497
=================================================
- Hits 20341 20340 -1
- Misses 3772 3773 +1
|
sitetester
requested review from
shuse2,
gkoumout and
ishantiw
and removed request for
shuse2
November 10, 2023 10:25
ishantiw
reviewed
Nov 14, 2023
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
sitetester
requested review from
AndreasKendziorra
and removed request for
gkoumout
November 16, 2023 09:55
AndreasKendziorra
suggested changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't check yet if all point reported in the issue were addressed.
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
…escribe('verifyRoutingRules'`
…both (mainchain & sidechain) cases
ishantiw
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from @AndreasKendziorra comment, a minor comment, else looks good to me
framework/test/unit/modules/interoperability/base_cross_chain_update_command.spec.ts
Outdated
Show resolved
Hide resolved
…no error throw from verifyRoutingRules
AndreasKendziorra
approved these changes
Nov 21, 2023
ishantiw
approved these changes
Nov 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8193
How was it solved?
How was it tested?
verifyRoutingRules
method, relevant tests moved to a separatedescribe('verifyRoutingRules')
expect
s relevant toCCMProcessedCode.INVALID_CCM_ROUTING_EXCEPTION
are now called once