Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update tests for interop cross chain updates #9138

Merged
merged 11 commits into from
Nov 23, 2023

Conversation

sitetester
Copy link
Contributor

What was the problem?

This PR resolves #8193

How was it solved?

How was it tested?

  • Since we have a separate verifyRoutingRules method, relevant tests moved to a separate describe('verifyRoutingRules')
  • Repeated expects relevant to CCMProcessedCode.INVALID_CCM_ROUTING_EXCEPTION are now called once

@sitetester sitetester self-assigned this Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #9138 (28ec134) into release/6.1.0 (799585e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.1.0    #9138      +/-   ##
=================================================
- Coverage          84.35%   84.35%   -0.01%     
=================================================
  Files                655      655              
  Lines              24113    24113              
  Branches            3497     3497              
=================================================
- Hits               20341    20340       -1     
- Misses              3772     3773       +1     
Files Coverage Δ
...nteroperability/base_cross_chain_update_command.ts 97.71% <ø> (ø)
...in/commands/submit_mainchain_cross_chain_update.ts 98.76% <100.00%> (ø)
...in/commands/submit_sidechain_cross_chain_update.ts 96.29% <100.00%> (ø)

... and 1 file with indirect coverage changes

@sitetester sitetester marked this pull request as ready for review November 10, 2023 10:25
@sitetester sitetester requested review from shuse2, gkoumout and ishantiw and removed request for shuse2 November 10, 2023 10:25
@sitetester sitetester requested review from AndreasKendziorra and removed request for gkoumout November 16, 2023 09:55
Copy link
Contributor

@AndreasKendziorra AndreasKendziorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check yet if all point reported in the issue were addressed.

Copy link
Contributor

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from @AndreasKendziorra comment, a minor comment, else looks good to me

@sitetester sitetester requested a review from ishantiw November 21, 2023 09:32
@ishantiw ishantiw merged commit 7d8301a into release/6.1.0 Nov 23, 2023
10 checks passed
@ishantiw ishantiw deleted the 8193-unit-test-review-interop-ccu-commands branch November 23, 2023 10:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants