This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishantiw
force-pushed
the
9195-improve-chain-connector-storage
branch
2 times, most recently
from
February 19, 2024 18:06
662d8ca
to
14d041e
Compare
ishantiw
force-pushed
the
9195-improve-chain-connector-storage
branch
from
March 5, 2024 14:38
ce0d7dc
to
b9fbad1
Compare
- Add config to take keepInclusionProofsForHeights and inclusionProofKeys - Add DB update to get/set/delete inclusionProofs - Add handler in new block event to save inclusion proofs - Add endpoint for chain to get inclusion proofs by height
- Improve storage to retrieve by key/val and delete efficiently instead of managing full array - Reduce number of RPC calls during new block event - Improve cleanup
ishantiw
force-pushed
the
9195-improve-chain-connector-storage
branch
from
March 6, 2024 12:26
b9fbad1
to
56cc560
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hotfix/6.0.2 #9198 +/- ##
================================================
- Coverage 83.52% 83.28% -0.24%
================================================
Files 606 608 +2
Lines 22890 23101 +211
Branches 3377 3379 +2
================================================
+ Hits 19118 19239 +121
- Misses 3772 3862 +90
|
ishantiw
force-pushed
the
9195-improve-chain-connector-storage
branch
from
March 12, 2024 14:29
aea9020
to
228050a
Compare
Incede
approved these changes
Mar 12, 2024
shuse2
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change in scope is quite big + im not fully understanding how plugin should work, so i might have missed something for the behavior.
Since it's plugin, i would assume as long as transaction is accepted on sidechain <=> mainchain scenario, it is fine
framework-plugins/lisk-framework-chain-connector-plugin/src/block_event_handler.ts
Outdated
Show resolved
Hide resolved
framework-plugins/lisk-framework-chain-connector-plugin/src/block_event_handler.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #9195
How was it solved?
How was it tested?