-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Gemfile & pin all gems #680
Conversation
We've been using PostgreSQL instead for a long time.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #680 +/- ##
======================================
Coverage ? 53.80%
======================================
Files ? 157
Lines ? 6644
Branches ? 0
======================================
Hits ? 3575
Misses ? 3069
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Indeed, SQlite has not been used by us for a long time.
main
branch>=
, but~>
instead, which will not automatically install major version updatesIn this PR, we don't update any dependencies, i.e. we didn't do
bundle update
, justbundle install
with the pinned versions. An exception is the SQLite dependency, which is removed as seen above.TODO