Make more variables const so we have more constexpr constructors #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback should not be modifiable once the instance is created.
They must not be modified after the instance creation.
They must not be modified after the instance creation.
They must not be modified after the instance creation.
It's more readable. Since C++14 https://en.cppreference.com/w/cpp/language/integer_literal
The EbmlDummy has a Create callback that is used in DEFINE_EBML_CLASS_ORPHAN().
It's using assert() twice. The other headers calling assert include it properly.
robUx4
added
api-break
mbunkus
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API is designed to set the values on creation and not touch them again.
Also change some integer constants so they are more readable.
The
EbmlSemanticContextcannot be aconstexpr(for now?) because it's exported asextern const.