Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make more variables const so we have more constexpr constructors #157

Merged
merged 13 commits into from
Dec 18, 2023
Merged

Make more variables const so we have more constexpr constructors #157

merged 13 commits into from
Dec 18, 2023

Commits on Dec 18, 2023

  1. make the EbmlCallbacks create function const 

    The callback should not be modifiable once the instance is created.
    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    fa2acf9 View commit details
    Browse the repository at this point in the history

  2. make the EbmlSemantic fields const 

    They must not be modified after the instance creation.
    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    cf9447e View commit details
    Browse the repository at this point in the history

  3. make the EbmlSemanticContext fields const 

    They must not be modified after the instance creation.
    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    17d2f72 View commit details
    Browse the repository at this point in the history

  4. make the EbmlId fields const 

    They must not be modified after the instance creation.
    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b28f161 View commit details
    Browse the repository at this point in the history

  5. make EbmlDate::UnixEpochDelay constexpr

    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    c866fef View commit details
    Browse the repository at this point in the history

  6. use separator in long integers 

    It's more readable. Since C++14 https://en.cppreference.com/w/cpp/language/integer_literal
    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    ecf3658 View commit details
    Browse the repository at this point in the history

  7. New allow an empty creator callback 

    The EbmlDummy has a Create callback that is used in DEFINE_EBML_CLASS_ORPHAN().
    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    0edd9ea View commit details
    Browse the repository at this point in the history

  8. include cassert in EbmlElement.h 

    It's using assert() twice. The other headers calling assert include it properly.
    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    50206b1 View commit details
    Browse the repository at this point in the history

  9. make the EbmlId constructor a constexpr

    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    32eb2b6 View commit details
    Browse the repository at this point in the history

  10. make the EbmlCallbacks constructor a constexpr

    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    4555495 View commit details
    Browse the repository at this point in the history

  11. make the EbmlSemanticContext constructor a constexpr

    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    0afeeaa View commit details
    Browse the repository at this point in the history

  12. initialize each class EbmlId as a constexpr

    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    333ce86 View commit details
    Browse the repository at this point in the history

  13. initialize each class EbmlCallbacks as a constexpr

    @robUx4
    robUx4 committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    aa49e1c View commit details
    Browse the repository at this point in the history