Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. CRC32 cleaning #189

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Misc. CRC32 cleaning #189

merged 3 commits into from
Dec 28, 2023

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Dec 28, 2023

No description provided.

@robUx4
use the C++11 alignof operator instead of compiler specific code
83a710b 
This should give the same result https://en.cppreference.com/w/cpp/language/alignof
@robUx4
don't export the CRC32 table
b4b56a6 
It was not exported properly when building a DLL. We it's not necessary
for other classes.
It can be restrictued to that C++ compilation unit that noone else will see.
@robUx4 robUx4 added the abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled) label Dec 28, 2023
mbunkus
mbunkus requested changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@mbunkus mbunkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename m_tab to s_tab in order to signal that it's a static variable, not a member variable?

@robUx4
Copy link
Contributor Author

robUx4 commented Dec 28, 2023

Maybe rename m_tab to s_tab in order to signal that it's a static variable, not a member variable?

Done

@robUx4 robUx4 requested a review from mbunkus December 28, 2023 14:52
@robUx4 robUx4 merged commit b042efa into Matroska-Org:master Dec 28, 2023
15 checks passed
@robUx4 robUx4 deleted the crc32 branch December 28, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbunkus mbunkus mbunkus approved these changes

Assignees
No one assigned
Labels
abi-break breaks the ABI (e.g. programs linked against the library have to be recompiled)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robUx4 @mbunkus