Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc. CRC32 cleaning #189

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Misc. CRC32 cleaning #189

merged 3 commits into from
Dec 28, 2023

Commits on Dec 28, 2023

  1. use the C++11 alignof operator instead of compiler specific code 

    This should give the same result https://en.cppreference.com/w/cpp/language/alignof
    @robUx4
    robUx4 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    83a710b View commit details
    Browse the repository at this point in the history

  2. don't export the CRC32 table 

    It was not exported properly when building a DLL. We it's not necessary
for other classes.
It can be restrictued to that C++ compilation unit that noone else will see.
    @robUx4
    robUx4 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    b4b56a6 View commit details
    Browse the repository at this point in the history

  3. crc32: rename m_tab to s_tab as it's a static local table

    @robUx4
    robUx4 committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    1f43ee3 View commit details
    Browse the repository at this point in the history