-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more GCC and Clang versions to CI. #233
Conversation
4654176
to
9febc82
Compare
No idea what this is. edit: this failure is with GCC7-9. |
815194d
to
e83c1ab
Compare
add_cxx_flag_if_supported seems to be broken looks like. |
ca0cd0f
to
5f6b23e
Compare
5f4c90c
to
ec24ef4
Compare
ce63d9d
to
d693526
Compare
Since the alpine targets are using gcc 13, we might drop the basic Linux + gcc 13 target |
3a82ad5
to
c292e6e
Compare
The README should be updated to show/remove some of the target status. |
It's been decided VLC will move to C17 (in addition to C++17) and we only support gcc from version 8 and clang from version 8: https://code.videolan.org/videolan/vlc/-/merge_requests/4858 IMO we don't need to support anything older in this new library version. |
@robUx4 that's cool. VLC is not a library. libebml is a much simpler codebase. It also doesn't take much to support older clang/gcc, |
a8881ea
to
6b144cf
Compare
VLC is a UI on top of libvlc which can be embedded in a lot of places (my day job). But I mention it here because with mkvtoolnix that's the main user of libebml. So if the minimum compiler is gcc 8 and clang 8, we probably don't need to support actively more than that. There's no need to add ugly hacks for these old compilers just because they are somehow supporting C++17. |
Looking at the list of checks, it seems the alpine builds take 2x longer to build. Can we have just one of them ? |
6e743fc
to
5e5123d
Compare
@robUx4 which do you prefer? |
Between |
|
Also WebAssembly is mostly 32-bit and we don't have a Linux 32-bit target. So maybe Yesterday I had trouble compiling Google's protobuf on iOS armv7 because of some alignment issues in AppleClang (fixed in Clang 16 which they don't have yet). So an armv7 with an older compiler (in this case not having aligned new) would be good. |
bfe52b3
to
f6bb185
Compare
7 is a good minimum. 13 is latest available. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Clang is stricter, especially when it comes to constexpr usage. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Allows to test multiple non x86 platforms. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Alpine now tests GCC13 for multiple platforms. No need to duplicate. Signed-off-by: Rosen Penev <rosenp@gmail.com>
@robUx4 reduced to just armhf. |
No description provided.