Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typed children macros instead of local casts #190

Merged
merged 5 commits into from
Mar 2, 2024
Merged

Use typed children macros instead of local casts #190

merged 5 commits into from
Mar 2, 2024

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Mar 2, 2024

No description provided.

@robUx4 robUx4 mentioned this pull request Mar 2, 2024
Merged
@mbunkus mbunkus merged commit 72d1291 into Matroska-Org:master Mar 2, 2024
0 of 15 checks passed
@robUx4 robUx4 deleted the typed_children branch March 2, 2024 12:38
@mbunkus mbunkus mentioned this pull request Mar 2, 2024
Merged
@robUx4 robUx4 restored the typed_children branch March 2, 2024 12:40
@mbunkus
Copy link
Contributor

mbunkus commented Mar 2, 2024

See Matroska-Org/libebml#285 for further discussion.

@robUx4
Copy link
Contributor Author

robUx4 commented Mar 2, 2024

There doesn't seem to be a way to reopen a PR. It has to be created from scratch again.

@mbunkus
Copy link
Contributor

mbunkus commented Mar 2, 2024

Yeah looks like it. Your libEBML typed_children as at 131905c457b2b0b6ee0f9526185748e0eb7874f0, your libMatroska typed_children at b2efa89.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbunkus mbunkus mbunkus approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robUx4 @mbunkus