Make more use of typed children macros and remove FindElt #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is exactly the same code.
It's a duplicate of EbmlMaster::FindFirstElt which is more often used. Only VLC uses it and it can be easily switched for all libebml versions.
If we don't want to create the element, we can use a const EbmlMaster
robUx4
added
api-break
mbunkus
approved these changes
Mar 2, 2024
|
Sorry, but I have to reverse this merge. Somehow I forgot to run my test suite after merging (doing too many things simultaneously…). There are many segfaults in MKVToolNix. Will have to look into them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindElt()is a duplicate ofFindFirstElt().This will require Matroska-Org/libmatroska#190 for libmatroska as it was using
FindElt()(and vice versa for the extra const).