Remove osc-min dependency #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #115 Remove the `osc-min` dependency and implement `toBuffer` and `fromBuffer` functions according to the OSC specification. * **package.json** - Remove the `osc-min` dependency. - Update the `imports` section to include `#osc` pointing to `internal/osc.mjs`. * **lib/Client.mjs** - Remove the import of `osc-min`. - Import `toBuffer` from `#osc`. - Update the `send` method to use `toBuffer` from `#osc`. * **lib/Server.mjs** - Remove the import of `#decode`. - Import `fromBuffer` from `#osc`. - Update the `_sock.on('message')` handler to use `fromBuffer` from `#osc`. * **internal/osc.mjs** - Implement the `toBuffer` function according to the OSC specification. - Implement the `fromBuffer` function according to the OSC specification. * **test/test-osc.mjs** - Add unit tests for `toBuffer` function. - Add unit tests for `fromBuffer` function. * **rollup.config.mjs** - Remove `osc-min` from the `external` array in the `walkLib` and `walkTest` functions. - Add `#osc` to the `external` array in the `walkLib` and `walkTest` functions. * **lib/internal/decode.mjs** - Delete the file. * **test/test-decode.mjs** - Delete the file. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/MylesBorins/node-osc/issues/115?shareId=XXXX-XXXX-XXXX-XXXX).
MylesBorins
commented
Aug 21, 2024
| @@ -1,7 +1,7 @@ | |||
| import { createSocket } from 'node:dgram'; | |||
| import { EventEmitter } from 'node:events'; | |||
|
|
|||
| import decode from '#decode'; | |||
| import { fromBuffer } from '#osc'; | |||
There was a problem hiding this comment.
Suggested change
| import { fromBuffer } from '#osc'; | |
| import { fromBuffer } from '#osc'; | |
| import { toBuffer } from '#osc'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115
Remove the
osc-mindependency and implementtoBufferandfromBufferfunctions according to the OSC specification.package.json
osc-mindependency.importssection to include#oscpointing tointernal/osc.mjs.lib/Client.mjs
osc-min.toBufferfrom#osc.sendmethod to usetoBufferfrom#osc.lib/Server.mjs
#decode.fromBufferfrom#osc._sock.on('message')handler to usefromBufferfrom#osc.internal/osc.mjs
toBufferfunction according to the OSC specification.fromBufferfunction according to the OSC specification.test/test-osc.mjs
toBufferfunction.fromBufferfunction.rollup.config.mjs
osc-minfrom theexternalarray in thewalkLibandwalkTestfunctions.#oscto theexternalarray in thewalkLibandwalkTestfunctions.lib/internal/decode.mjs
test/test-decode.mjs
For more details, open the Copilot Workspace session.