Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove osc-min dependency #124

Closed
wants to merge 3 commits into from
Closed

Remove osc-min dependency #124

wants to merge 3 commits into from

Commits on Aug 20, 2024

  1. Remove osc-min dependency

    Fixes #115
    
    Remove the `osc-min` dependency and implement `toBuffer` and `fromBuffer` functions according to the OSC specification.
    
    * **package.json**
      - Remove the `osc-min` dependency.
      - Update the `imports` section to include `#osc` pointing to `internal/osc.mjs`.
    
    * **lib/Client.mjs**
      - Remove the import of `osc-min`.
      - Import `toBuffer` from `#osc`.
      - Update the `send` method to use `toBuffer` from `#osc`.
    
    * **lib/Server.mjs**
      - Remove the import of `#decode`.
      - Import `fromBuffer` from `#osc`.
      - Update the `_sock.on('message')` handler to use `fromBuffer` from `#osc`.
    
    * **internal/osc.mjs**
      - Implement the `toBuffer` function according to the OSC specification.
      - Implement the `fromBuffer` function according to the OSC specification.
    
    * **test/test-osc.mjs**
      - Add unit tests for `toBuffer` function.
      - Add unit tests for `fromBuffer` function.
    
    * **rollup.config.mjs**
      - Remove `osc-min` from the `external` array in the `walkLib` and `walkTest` functions.
      - Add `#osc` to the `external` array in the `walkLib` and `walkTest` functions.
    
    * **lib/internal/decode.mjs**
      - Delete the file.
    
    * **test/test-decode.mjs**
      - Delete the file.
    
    ---
    
    For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/MylesBorins/node-osc/issues/115?shareId=XXXX-XXXX-XXXX-XXXX).
    MylesBorins committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    2191be3 View commit details
    Browse the repository at this point in the history
  2. fixup

    MylesBorins authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    150067b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. restore package.json

    MylesBorins authored Aug 21, 2024
    Configuration menu
    Copy the full SHA
    61c136b View commit details
    Browse the repository at this point in the history