Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import myosuite before sb3 to ensure envs are registered #270

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

fl0fischer
Copy link
Contributor

@fl0fischer fl0fischer commented Dec 18, 2024

For some SLURM/HPC setups, the registered MyoSuite envs are not recognised correctly when using Hydra.
In particular, the job terminates with error "gymnasium.error.NameNotFound: Environment ... doesn't exist".

This can be fixed by importing myosuite in the sb3_job_script.py before sb3 (which loads gymnasium) is imported.

I have not tested whether the same issue occurs when using torchrl_job_script.py, but a similar fix may be required.

Copy link
Collaborator

@Vittorio-Caggiano Vittorio-Caggiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Vittorio-Caggiano Vittorio-Caggiano changed the base branch from main to dev December 18, 2024 23:04
@Vittorio-Caggiano Vittorio-Caggiano merged commit e2d1eb3 into MyoHub:dev Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants