Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add UDP checksum #67

Merged
merged 1 commit into from
Dec 1, 2023
Merged

feat: add UDP checksum #67

merged 1 commit into from
Dec 1, 2023

Conversation

jpcsmith
Copy link
Contributor

@jpcsmith jpcsmith commented Nov 29, 2023 •
edited
Loading

Closes #62

@jpcsmith jpcsmith self-assigned this Nov 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2023 •
edited
Loading

Code Coverage

Package Line Rate Health
crates/scion-proto/src/path/metadata 100% ✔
crates/scion-proto/src/path 84% ✔
crates/scion-proto/src/reliable 97% ✔
crates/scion-proto/src/address 72% ➖
crates/scion-proto/src 79% ✔
crates/scion-proto/src/packet 79% ✔
crates/scion/src/daemon 94% ✔
crates/scion/src 66% ➖
crates/scion/src/udp 0% ❌
Summary 77% (709 / 916) ✔

mlegner
mlegner requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this important PR, @jpcsmith!

I believe I found 2 issues, but I'm not 100% sure about them. Please take a look and let me know.

crates/scion-proto/src/packet/checksum.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/packet/checksum.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/packet/checksum.rs Outdated Show resolved Hide resolved
crates/scion-proto/src/packet/checksum.rs Outdated Show resolved Hide resolved
@jpcsmith jpcsmith mentioned this pull request Nov 30, 2023
Merged
mlegner
mlegner approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the work and comparison! LGTM. 💯

@jpcsmith jpcsmith closed this Dec 1, 2023
@mlegner
Copy link
Contributor

mlegner commented Dec 1, 2023

@jpcsmith Question: What is the plan with this PR, are you going to recreate it somewhere?

@jpcsmith jpcsmith reopened this Dec 1, 2023
@jpcsmith
Copy link
Contributor Author

jpcsmith commented Dec 1, 2023

@mlegner That was not at all intentional. I thought it had merged in automatically.

@jpcsmith jpcsmith merged commit c9c39b0 into main Dec 1, 2023
11 checks passed
@jpcsmith jpcsmith deleted the feat/udp-checksum branch December 1, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlegner mlegner mlegner approved these changes

Assignees

@jpcsmith jpcsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement SCION UDP checksum calculation
2 participants
@jpcsmith @mlegner