Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cloud config for local vm deployment #93

Merged
merged 1 commit into from
Dec 12, 2023
Merged

feat: add cloud config for local vm deployment #93

merged 1 commit into from
Dec 12, 2023

Conversation

jpcsmith
Copy link
Contributor

@jpcsmith jpcsmith commented Dec 11, 2023 •
edited
Loading

This adds a cloud-config to use with multipass for setting up SCION in a VM for integration tests.

The commands to get a working VM for the tests would then be:

multipass launch -n scion --disk 10G --memory 4G --cpus 2 --cloud-init multipass/cloud-config.yaml --timeout 600
. multipass/test_setup.sh

Progress:

  • Implement cloud-config
  • Update documentation

jpcsmith
jpcsmith commented Dec 12, 2023
View reviewed changes
multipass/test_setup.sh Outdated Show resolved Hide resolved
jpcsmith
jpcsmith commented Dec 12, 2023
View reviewed changes
multipass/test_id_ed25519 Outdated Show resolved Hide resolved
@jpcsmith jpcsmith self-assigned this Dec 12, 2023
mlegner
mlegner reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these setup improvements. Probably I should have gone that route from the beginning... 🙂

multipass/test_setup.sh Outdated Show resolved Hide resolved
multipass/test_id_ed25519 Outdated Show resolved Hide resolved
@jpcsmith jpcsmith marked this pull request as ready for review December 12, 2023 09:10
mlegner
mlegner requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small issues and a nit.

CONTRIBUTING.md Outdated Show resolved Hide resolved
multipass/test_setup.sh Show resolved Hide resolved
multipass/test_id_ed25519 Outdated Show resolved Hide resolved
@jpcsmith jpcsmith force-pushed the ci/cloud-init branch 2 times, most recently from 3890285 to ac57004 Compare December 12, 2023 11:27
mlegner
mlegner approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot for the changes. This looks good to me, just one nit left.

@jpcsmith
Copy link
Contributor Author

@mlegner Oh, what did I miss?

@jpcsmith jpcsmith enabled auto-merge (rebase) December 12, 2023 12:51
@jpcsmith jpcsmith merged commit 9a574bd into main Dec 12, 2023
11 checks passed
@jpcsmith jpcsmith deleted the ci/cloud-init branch December 12, 2023 12:52
@mlegner mlegner mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlegner mlegner mlegner approved these changes

Assignees

@jpcsmith jpcsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpcsmith @mlegner