Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule atmos_cubed_sphere to fix a typo/bug when printing out the nest grid corner locations #847

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

BinLiu-NOAA
Copy link
Collaborator

@BinLiu-NOAA BinLiu-NOAA commented Jun 13, 2024

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?

Update submodule atmos_cubed_sphere to fix a typo/bug when printing out the nest grid corner locations.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

This fix has been tested with the UFS HAFS application.

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@zach1221
Copy link
Collaborator

Hello, @BrianCurtis-NOAA @DusanJovic-NOAA . Could you provide review of this PR please?

@FernandoAndrade-NOAA
Copy link

atmos_cubed_sphere 341 was merged in, please revert .gitmodules and sync hashes before proceeding with the merge process, thank you.

@jkbk2004 jkbk2004 merged commit 10cd023 into NOAA-EMC:develop Jun 25, 2024
6 checks passed
@BinLiu-NOAA BinLiu-NOAA deleted the feature/grid_corner_jc_fix branch June 28, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo/bug in fv_grid_tools.F90 in dev/emc branch when print out grid corner indexes and locations
5 participants