Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the jc index when print out the nest grid corner locations #341

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

BinLiu-NOAA
Copy link

@BinLiu-NOAA BinLiu-NOAA commented May 13, 2024

Description

This PR fixes a typo/bug when printing out the nest grid corner locations in tools/fv_grid_tools.F90.

Fixes #333

Related ufs-weather-model PRs:

How Has This Been Tested?
The fix has been tested in the HAFS application with ufs-weather-model.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@lharris4
Copy link
Contributor

@laurenchilutti should we go ahead and merge? BTW I would like to merge this into the main branch for the upcoming release.

@laurenchilutti
Copy link
Contributor

We have to wait for the UFS code managers to give us the "OK" to merge PRs directed at the dev/emc branch.
@BinLiu-NOAA have you created PRs in fv3atm and ufs-weather-model for this change?

@BinLiu-NOAA
Copy link
Author

We have to wait for the UFS code managers to give us the "OK" to merge PRs directed at the dev/emc branch. @BinLiu-NOAA have you created PRs in fv3atm and ufs-weather-model for this change?

@laurenchilutti I have created related PRs at FV3atm and ufs-weather-model levels. We can bring this up in tomorrow's UFS apps and components coordination meeting to discuss and coordinate on how to merge this series of PRs. Hopefully can be combined with another PR to speed up the process. Thanks!

@FernandoAndrade-NOAA
Copy link

Testing for #2324 is complete, please continue with merging this PR.

@FernandoAndrade-NOAA
Copy link

Correction - Please do not merge yet, there is still a missing commit on the WM side.

@bensonr bensonr merged commit 523f5a3 into NOAA-GFDL:dev/emc Jun 25, 2024
@FernandoAndrade-NOAA
Copy link

We should be all set here, sorry for any confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants