Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo/bug in fv_grid_tools.F90 in dev/emc branch when print out grid corner indexes and locations #333

Closed
BinLiu-NOAA opened this issue Apr 9, 2024 · 3 comments · Fixed by NOAA-EMC/fv3atm#847

Comments

@BinLiu-NOAA
Copy link

Describe the bug
There is a typo/bug in fv_grid_tools.F90 when print out the grid SW, NW, NE, SE CORNER indexes and lat/lon locations.
The source code lines of
ic = p_ind(1,1,1) ; jc = p_ind(1,1,1)
should be updated into:
ic = p_ind(1,1,1) ; jc = p_ind(1,1,2)
so that the jc gets the correct index. Otherwise, jc is always identical to ic, leading to wrong printout jc and lat/lon locations for the grid corners.

Additional context
This bug/typo was found/identified when checking UFS-HAFS moving-nesting forecast log. And you can see an proposed/example fix from this commit 4162fad.

@lharris4
Copy link
Contributor

lharris4 commented May 7, 2024

Sorry for the delay @BinLiu-NOAA . I think you are correct. Could you go ahead and create an MR?

Thanks,
Lucas

@BinLiu-NOAA
Copy link
Author

Sorry for the delay @BinLiu-NOAA . I think you are correct. Could you go ahead and create an MR?

Thanks, Lucas

Thanks, @lharris4! PR #341 has been created accordingly to address this issue.

@bensonr
Copy link
Contributor

bensonr commented Jun 25, 2024

merged into dev/emc branch with PR #341

@bensonr bensonr closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment