Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and centralize ngen-related images #408

Commits on Aug 28, 2023

  1. Updates to ngen Docker image entrypoint script.

    Move ngen entrypoint args to use of explicit flags and to use of single
    composite config dataset arg/name/directory.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e5d0976 View commit details
    Browse the repository at this point in the history
  2. Have ngen entrypoint copy configs to output.

    Updating entrypoint.sh to copy various job-related configs into output
    dataset for record keeping and reproducibility.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    04e3190 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    480a91f View commit details
    Browse the repository at this point in the history
  4. Explicit build stage name for ngen Docker image.

    Updating Dockerfile to give name to the build stage used as main "ngen"
    worker image for model exec jobs, and updating docker-build.yml build
    setup accordingly to explicitly target this stage.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9f7c589 View commit details
    Browse the repository at this point in the history
  5. Move ngen entrypoint common logic and functions.

    Moving reusable functions and logic not (yet) in functions from ngen
    entrypoint.sh to functions within new funcs.sh, and sourcing the new
    file from the entrypoint.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5f67961 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8dd78be View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    79db267 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    61c45bb View commit details
    Browse the repository at this point in the history
  9. Move partitioner image entrypoint.

    Moving entrypoint script (and renaming) for partitioner image to ngen
    directory/build context in preparation for working from the same
    Dockerfile.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    18ad2f0 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7924af4 View commit details
    Browse the repository at this point in the history
  11. Update ngen build to let Boost be cleaned up.

    Updating rocky-ngen-deps build stage in ngen Dockerfile so that Boost
    root directory (after downloaded Boost headers are untarred) is chowned
    to USER value, so the directory can be deleted later.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    dd4e138 View commit details
    Browse the repository at this point in the history
  12. Fix ngen funcs for handling object store secrets.

    Fixing function to actually load the secrets for ACCESS and SECRET to
    variables.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    4ce9a6a View commit details
    Browse the repository at this point in the history
  13. Create ngen Dockerfile partitioner build stage.

    Creating custom build stage for use as the ngen-partitioner image
    target.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    baed1df View commit details
    Browse the repository at this point in the history
  14. Update ngen-partitioner compose build config.

    Updating docker-build.yml to use context and Dockerfile from main ngen
    image and specify new custom target set up for partitioner image.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    53a5175 View commit details
    Browse the repository at this point in the history
  15. Delete obsolete ngen-partitioner Dockerfile.

    Removing old stand-alone partitioner Dockerfile after moving to stage
    within main ngen Dockerfile.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f3ca25d View commit details
    Browse the repository at this point in the history
  16. Adjust entrypoint in partitioner image.

    Adjusting entrypoint setup to reduce layers and use standardized name
    for entrypoint script once it is inside the image/container.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    80fbe64 View commit details
    Browse the repository at this point in the history
  17. Adjust entrypoint in ngen image.

    Adjusting entrypoint setup to use standardized name for entrypoint
    script once it is inside the image/container.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0f2f4a6 View commit details
    Browse the repository at this point in the history
  18. Moving ngen-cal image entrypoint script.

    Moving and renaming entrypoint script for ngen_cal image to be within
    context directory for ngen image build, in preparation for utilizing
    a stage within the main Dockerfile for the calibration image.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    39e6217 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    b519ad8 View commit details
    Browse the repository at this point in the history
  20. Fix ngen entrypoint handling for serial run.

    Fixing logic in script for how things were handled when running a
    serial execution.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c9607ce View commit details
    Browse the repository at this point in the history
  21. Fix func to init and sanity ngen exec.

    Fixing issue in funcs.sh related to when to check for a partition config
    dataset directory, which previously would only happen if the MPI node
    count was greater than 1 (i.e., while an MPI job running all on a single
    node would still expect the partition config).
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    05fa516 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    a474b88 View commit details
    Browse the repository at this point in the history
  23. Update ngen Dockerfile for ngen_cal image.

    Updating main ngen Dockerfile with new build stage for use as target for
    ngen_cal worker image.
    robertbartel committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9958bc8 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    498466a View commit details
    Browse the repository at this point in the history