Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and centralize ngen-related images #408

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
e5d0976
Updates to ngen Docker image entrypoint script.
robertbartel Jul 20, 2023
04e3190
Have ngen entrypoint copy configs to output.
robertbartel Jul 26, 2023
480a91f
Remove separated, obsolete ngen-deps Dockerfile.
robertbartel Jul 31, 2023
9f7c589
Explicit build stage name for ngen Docker image.
robertbartel Jul 31, 2023
5f67961
Move ngen entrypoint common logic and functions.
robertbartel Aug 1, 2023
8dd78be
Copy funcs.sh file in ngen Docker image build.
robertbartel Aug 1, 2023
79db267
Rename ngen entrypoint.sh to ngen_entrypoint.sh.
robertbartel Aug 1, 2023
61c45bb
Update ngen Dockerfile for renamed entrypoint.
robertbartel Aug 1, 2023
18ad2f0
Move partitioner image entrypoint.
robertbartel Aug 1, 2023
7924af4
Updates to partitioner image entrypoint.
robertbartel Aug 1, 2023
dd4e138
Update ngen build to let Boost be cleaned up.
robertbartel Aug 1, 2023
4ce9a6a
Fix ngen funcs for handling object store secrets.
robertbartel Aug 1, 2023
baed1df
Create ngen Dockerfile partitioner build stage.
robertbartel Aug 1, 2023
53a5175
Update ngen-partitioner compose build config.
robertbartel Aug 1, 2023
f3ca25d
Delete obsolete ngen-partitioner Dockerfile.
robertbartel Aug 1, 2023
80fbe64
Adjust entrypoint in partitioner image.
robertbartel Aug 2, 2023
0f2f4a6
Adjust entrypoint in ngen image.
robertbartel Aug 2, 2023
39e6217
Moving ngen-cal image entrypoint script.
robertbartel Aug 2, 2023
b519ad8
Refactor ngen_cal entrypoint for shared scripts.
robertbartel Aug 2, 2023
c9607ce
Fix ngen entrypoint handling for serial run.
robertbartel Aug 2, 2023
05fa516
Fix func to init and sanity ngen exec.
robertbartel Aug 2, 2023
a474b88
Update ngen_cal entrypoint.
robertbartel Aug 2, 2023
9958bc8
Update ngen Dockerfile for ngen_cal image.
robertbartel Aug 2, 2023
498466a
Update Docker build config for ngen_cal image.
robertbartel Aug 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions docker/main/docker-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ services:
image: ${DOCKER_INTERNAL_REGISTRY:?}/ngen:${NGEN_VERSION:-latest}
build:
context: ./ngen
target: ngen_worker
args:
REPO_URL: ${NGEN_REPO_URL?No NGen repo url configured}
BRANCH: ${NGEN_BRANCH?No NGen branch configured}
Expand All @@ -83,7 +84,8 @@ services:
ngen-partitioner:
image: ${DOCKER_INTERNAL_REGISTRY:?}/${DOCKER_PARTITIONER_IMAGE:-ngen-partitioner}
build:
context: ./ngen-partitioner
context: ./ngen
target: partitioner_image
args:
REPO_URL: ${NGEN_REPO_URL?No NGen repo url configured}
BRANCH: ${NGEN_BRANCH?No NGen branch configured}
Expand All @@ -97,16 +99,16 @@ services:
ngen-calibration:
image: ${DOCKER_INTERNAL_REGISTRY:?}/ngen-calibration:${NGEN_CAL_IMAGE_TAG:-latest}
build:
context: ./ngen-calibration
context: ./ngen
target: ngen_cal_worker
args:
BASE_NGEN_IMAGE_TAG: ${NGEN_CAL_BASE_IMAGE_TAG:-latest}
#REPO_URL: ${NGEN_REPO_URL?No NGen repo url configured}
REPO_URL: ${NGEN_REPO_URL?No NGen repo url configured}
NGEN_CAL_BRANCH: ${NGEN_CAL_BRANCH:-master}
NGEN_CAL_COMMIT: ${NGEN_CAL_COMMIT}
#TROUTE_REPO_URL: ${TROUTE_REPO_URL?No t-route repo url configured}
#TROUTE_BRANCH: ${TROUTE_BRANCH?No t-route branch configured}
#TROUTE_COMMIT: ${TROUTE_COMMIT}
#BUILD_PARALLEL_JOBS: ${NGEN_BUILD_PARALLEL_JOBS:-2}
TROUTE_REPO_URL: ${TROUTE_REPO_URL?No t-route repo url configured}
TROUTE_BRANCH: ${TROUTE_BRANCH?No t-route branch configured}
TROUTE_COMMIT: ${TROUTE_COMMIT}
BUILD_PARALLEL_JOBS: ${NGEN_BUILD_PARALLEL_JOBS:-2}
DOCKER_INTERNAL_REGISTRY: ${DOCKER_INTERNAL_REGISTRY:?}
depends_on:
- ngen
Expand Down
171 changes: 0 additions & 171 deletions docker/main/ngen-calibration/entrypoint.sh

This file was deleted.

51 changes: 0 additions & 51 deletions docker/main/ngen-partitioner/Dockerfile

This file was deleted.

109 changes: 0 additions & 109 deletions docker/main/ngen-partitioner/entrypoint.sh

This file was deleted.

Loading
Loading