Bug fix arg connected comp #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
* ci: Run gpuci on main * fix checkout Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
* build: Add conda env to `$PATH` Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * test Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * add newline Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * run cleanup always Signed-off-by: Oliver Koenig <okoenig@nvidia.com> --------- Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
* Create build-test-publish-wheel.yml Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Create package_info.py Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * run black Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update __init__.py Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update package_info.py Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update .github/workflows/build-test-publish-wheel.yml Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * remove extra version string Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update __init__.py Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * add `__all__` Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Fix version Signed-off-by: oliver könig <okoenig@nvidia.com> * Update .github/workflows/build-test-publish-wheel.yml Signed-off-by: oliver könig <okoenig@nvidia.com> * Ko3n1g/sarahyurick/ci/build test publish wheel (NVIDIA#358) * fix * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix * fix --------- Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * run black Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * run isort Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update __init__.py Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update pyproject.toml Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> --------- Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
* Update build-test-publish-wheel.yml Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update Dockerfile Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update build-test-publish-wheel.yml Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> --------- Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
* chore: Add `CHANGELOG.md` file * fix * add end of line Signed-off-by: Oliver Koenig <okoenig@nvidia.com> --------- Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
* add file Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * trailing whitespace Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> --------- Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
* ci: Bump release workflow for `devN` Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> --------- Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
* ci: Add cherry pick workflow Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> --------- Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
* add packaging Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * move to requires Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * move to github ci file Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add pin Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add torch Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add suggestion from mamba readme Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * try github install Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add comma Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * another attempt Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * remove nemo toolkit Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add datasets Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * try removing cython Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * remove cython Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * sentencepiece Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * run black Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * apply ryan's suggestion Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> --------- Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
* filter_files_by_extension function Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add type checking Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add filter_by param to get_all_files_paths_under Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * isort Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * address ayush's comments Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * run black Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * trailing whitespace Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * more whitespace Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * address praateek's review Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * praateek's review Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> --------- Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
davzoku
force-pushed
the
bug_fix_arg_connected_comp
branch
from
f61a4b3
to
cb173dd
Compare
VibhuJawa
approved these changes
Nov 19, 2024
|
@davzoku , Please let me know if this is good to merge on your end too . Thanks again for fixing this. |
|
Yup! All good, @VibhuJawa |
vinay-raman
pushed a commit
to vinay-raman/NeMo-Curator
that referenced
this pull request
Nov 26, 2024
* update obsolete flag Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * build: Improve caching (NVIDIA#352) Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * ci: Run on main (NVIDIA#354) * ci: Run gpuci on main * fix checkout Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * ci: Run on merge commit (NVIDIA#355) Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * build: Add conda env to `$PATH` (NVIDIA#357) * build: Add conda env to `$PATH` Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * test Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * add newline Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * run cleanup always Signed-off-by: Oliver Koenig <okoenig@nvidia.com> --------- Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * Add `build-test-publish-wheel` CI file (NVIDIA#356) * Create build-test-publish-wheel.yml Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Create package_info.py Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * run black Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update __init__.py Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update package_info.py Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update .github/workflows/build-test-publish-wheel.yml Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * remove extra version string Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update __init__.py Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * add `__all__` Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Fix version Signed-off-by: oliver könig <okoenig@nvidia.com> * Update .github/workflows/build-test-publish-wheel.yml Signed-off-by: oliver könig <okoenig@nvidia.com> * Ko3n1g/sarahyurick/ci/build test publish wheel (NVIDIA#358) * fix * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix * fix --------- Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * run black Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * run isort Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update __init__.py Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update pyproject.toml Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> --------- Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * Fix broken TestPyPi builder (NVIDIA#362) * Update build-test-publish-wheel.yml Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update Dockerfile Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> * Update build-test-publish-wheel.yml Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> --------- Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * chore: Add `CHANGELOG.md` file (NVIDIA#359) * chore: Add `CHANGELOG.md` file * fix * add end of line Signed-off-by: Oliver Koenig <okoenig@nvidia.com> --------- Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * Release workflow (NVIDIA#360) * add file Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * trailing whitespace Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> --------- Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * ci: Bump release workflow to allow of `devN` semver (NVIDIA#366) * ci: Bump release workflow for `devN` Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> --------- Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * ci: Add code-freeze workflow (NVIDIA#367) Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * ci: Add cherry pick workflow (NVIDIA#368) * ci: Add cherry pick workflow Signed-off-by: Oliver Koenig <okoenig@nvidia.com> * fix Signed-off-by: Oliver Koenig <okoenig@nvidia.com> --------- Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * Fix broken NeMo dependencies (NVIDIA#372) * add packaging Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * move to requires Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * move to github ci file Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add pin Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add torch Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add suggestion from mamba readme Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * try github install Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add comma Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * another attempt Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * remove nemo toolkit Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add datasets Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * try removing cython Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * remove cython Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * sentencepiece Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * run black Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * apply ryan's suggestion Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> --------- Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * ci: Bump release workflow (NVIDIA#373) Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * Skip reading files with incorrect extension (NVIDIA#318) * filter_files_by_extension function Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add type checking Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add filter_by param to get_all_files_paths_under Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * isort Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * address ayush's comments Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * run black Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * trailing whitespace Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * more whitespace Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * address praateek's review Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * praateek's review Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> --------- Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> * remove deprecated convert_str_ids args from ConnectedComponents Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> --------- Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com> Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> Co-authored-by: oliver könig <okoenig@nvidia.com> Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Vinay Raman <viraman@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #380 by removing deprecated args
convert_str_idsfromConnectedComponentsclass. This arg was removed in 36fcf50Usage
see results below.
Results