Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix arg connected comp #382

Merged
merged 17 commits into from
Nov 19, 2024
Merged

Bug fix arg connected comp #382

merged 17 commits into from
Nov 19, 2024

Commits on Nov 19, 2024

  1. update obsolete flag 

    Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @davzoku
    davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7f238a5 View commit details
    Browse the repository at this point in the history

  2. build: Improve caching (NVIDIA#352) 

    Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @ko3n1g @davzoku
    ko3n1g authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0441d89 View commit details
    Browse the repository at this point in the history

  3. ci: Run on main (NVIDIA#354) 

    * ci: Run gpuci on main
* fix checkout

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @ko3n1g @davzoku
    ko3n1g authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    44bbdaf View commit details
    Browse the repository at this point in the history

  4. ci: Run on merge commit (NVIDIA#355) 

    Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @ko3n1g @davzoku
    ko3n1g authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    aa31da6 View commit details
    Browse the repository at this point in the history

  5. build: Add conda env to $PATH (NVIDIA#357) 

    * build: Add conda env to `$PATH`

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* test

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* add newline

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* run cleanup always

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

---------

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @ko3n1g @davzoku
    ko3n1g authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a43bc09 View commit details
    Browse the repository at this point in the history

  6. Add build-test-publish-wheel CI file (NVIDIA#356) 

    * Create build-test-publish-wheel.yml

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* Create package_info.py

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* run black

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* Update __init__.py

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* Update package_info.py

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* Update .github/workflows/build-test-publish-wheel.yml

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* remove extra version string

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* Update __init__.py

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* add `__all__`

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* Fix version

Signed-off-by: oliver könig <okoenig@nvidia.com>

* Update .github/workflows/build-test-publish-wheel.yml

Signed-off-by: oliver könig <okoenig@nvidia.com>

* Ko3n1g/sarahyurick/ci/build test publish wheel (NVIDIA#358)

* fix

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

* fix

---------

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* run black

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* run isort

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* Update __init__.py

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* Update pyproject.toml

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

---------

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @sarahyurick @ko3n1g @davzoku
    2 people authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    6a78779 View commit details
    Browse the repository at this point in the history

  7. Fix broken TestPyPi builder (NVIDIA#362) 

    * Update build-test-publish-wheel.yml

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* Update Dockerfile

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

* Update build-test-publish-wheel.yml

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>

---------

Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @sarahyurick @davzoku
    sarahyurick authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d6d9116 View commit details
    Browse the repository at this point in the history

  8. chore: Add CHANGELOG.md file (NVIDIA#359) 

    * chore: Add `CHANGELOG.md` file

* fix

* add end of line

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

---------

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @ko3n1g @davzoku
    ko3n1g authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    195398c View commit details
    Browse the repository at this point in the history

  9. Release workflow (NVIDIA#360) 

    * add file

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* trailing whitespace

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

---------

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @sarahyurick @davzoku
    sarahyurick authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    8fb572d View commit details
    Browse the repository at this point in the history

  10. ci: Bump release workflow to allow of devN semver (NVIDIA#366) 

    * ci: Bump release workflow for `devN`

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

---------

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @ko3n1g @davzoku
    ko3n1g authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c4b4a4b View commit details
    Browse the repository at this point in the history

  11. ci: Add code-freeze workflow (NVIDIA#367) 

    Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @ko3n1g @davzoku
    ko3n1g authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b341919 View commit details
    Browse the repository at this point in the history

  12. ci: Add cherry pick workflow (NVIDIA#368) 

    * ci: Add cherry pick workflow

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

* fix

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>

---------

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @ko3n1g @davzoku
    ko3n1g authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    1f65054 View commit details
    Browse the repository at this point in the history

  13. Fix broken NeMo dependencies (NVIDIA#372) 

    * add packaging

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* move to requires

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* move to github ci file

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* add pin

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* add torch

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* add suggestion from mamba readme

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* try github install

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* add comma

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* another attempt

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* remove nemo toolkit

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* add datasets

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* try removing cython

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* remove cython

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* sentencepiece

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* run black

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* apply ryan's suggestion

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

---------

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @sarahyurick @davzoku
    sarahyurick authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    a1cbdd3 View commit details
    Browse the repository at this point in the history

  14. ci: Bump release workflow (NVIDIA#373) 

    Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @ko3n1g @davzoku
    ko3n1g authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    14f5a09 View commit details
    Browse the repository at this point in the history

  15. Skip reading files with incorrect extension (NVIDIA#318) 

    * filter_files_by_extension function

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* add type checking

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* add filter_by param to get_all_files_paths_under

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* isort

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* address ayush's comments

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* run black

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* trailing whitespace

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* more whitespace

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* address praateek's review

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

* praateek's review

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>

---------

Signed-off-by: Sarah Yurick <sarahyurick@gmail.com>
Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>
Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @sarahyurick @davzoku
    sarahyurick authored and davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bc19a32 View commit details
    Browse the repository at this point in the history

  16. remove deprecated convert_str_ids args from ConnectedComponents 

    Signed-off-by: Walter Teng <16046667+davzoku@users.noreply.github.com>
    @davzoku
    davzoku committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    cb173dd View commit details
    Browse the repository at this point in the history

  17. Merge branch 'main' into bug_fix_arg_connected_comp

    @davzoku
    davzoku authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c5709e2 View commit details
    Browse the repository at this point in the history