-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xFail known bad tests on H100 and fix CVEs #549
Merged
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Known issue on H100 (and GH200) with loading checkpoints. Also fixing CVE in ARM container
gagank1
requested review from
jstjohn,
malcolmgreaves,
skothenhill-nv,
dorotat-nv and
pstjohn
as code owners
December 18, 2024 23:53
/build-ci |
cspades
approved these changes
Dec 19, 2024
pstjohn
approved these changes
Dec 19, 2024
sub-packages/bionemo-geneformer/tests/bionemo/geneformer/test_model.py
Outdated
Show resolved
Hide resolved
jstjohn
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve but please make the test only xfail when not on H100 (or see my suggestion about also testing for cudnn version since I think it should work again with newer cuDNN, eg when we upgrade the base pytorch container to 24.10-py3.)
skothenhill-nv
approved these changes
Dec 19, 2024
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.